D6 is out!

-Port to D6
-Get the sort by node type patch in.

Comments

BarisW’s picture

Subscribing.

Would love to have the 6.x version!

dennys’s picture

Subscribing

zilla’s picture

would love to see this in d6, wish i could write code, dammit...

draeton’s picture

Status: Active » Needs review
StatusFileSize
new3.76 KB

This is my first attempted patch, but I've got Similar by Terms working in Drupal 6.

jjeff’s picture

draeton,

Looks great! However, I think you got a few (if not all) of your diff commands backwards, so instead of the new stuff showing "+", it shows "-". Your patch won't apply because it's actually saying to remove the code that you're adding and add the code that you're removing. :-)

But looking at things without actually testing things yet, it looks pretty good. I think you want to just switch the first and second arguments of the diff command that you're entering and you should be all set.

You've got:

diff -upN newfile oldfile

and it should be:

diff -upN oldfile newfile

draeton’s picture

StatusFileSize
new3.76 KB

See attached. I think I've got it right, this time.

designerbrent’s picture

Subscribe

rmiddle’s picture

Patch still doesn't apply for me. I went thought and manually made the changes. I get the following error tiring the patch.

Fatal error: Call to undefined function theme_similarterms() in /home/aapoliti/www/d6/sites/all/modules/similarterms/similarterms.module on line 68

encho’s picture

subscribing

greenskunk’s picture

Subscribing

designerbrent’s picture

Status: Needs review » Reviewed & tested by the community

This patch applied fine for me and seems to be working as desired.

rmiddle’s picture

StatusFileSize
new8.01 KB
new4.86 KB

I couldn't get that patch to apply cleanly. I figured out that it was created under the wrong folder structure. I manually applied the patch but the following two lines wouldn't work for me and I can't confirm that they should have worked after moving of the theme function to a template file.

$block['content'] = theme_similarterms(similarterms_list());

and

$block['content'] = theme_similarterms(similarterms_list($delta));

wouldn't work so I changed them to

$block['content'] = theme('similarterms', similarterms_list());
$block['content'] = theme('similarterms', similarterms_list($delta));

and the module started to work. I am not sure why it didn't work in my test 6 environment but did work in the other two environments but based on the way core handles this I am guessing this is closers to the standard.

Thanks
Robert

Attached is my patch and a full archive of all 5 files.

rmiddle’s picture

Status: Reviewed & tested by the community » Needs review
designerbrent’s picture

Status: Needs review » Reviewed & tested by the community

Robert,

This patch applied cleanly for me and appears to work fine.

Rob T’s picture

THe attached tar.gx module provided in #12 worked for me, but I am unable to get the block configuration changes to stick. Even though I've changed the "Item count" to 15, the block still only displays 5 items.

rmiddle’s picture

OK I see it. The item count changes but doesn't apply to the number displayed. I will take a look at that this weekend.

Thanks
Robert

rmiddle’s picture

StatusFileSize
new8.32 KB
new4.97 KB

Ok here is the updated patch that makes use of that variable. Hopeful between the two of us who have worked on this patch. Hopefully we haven't missed anything.

Thanks
Robert

Rob T’s picture

Yup... Item Count in the block configuration works now. Thanks so much.

Anonymous’s picture

The patched version works for me. Thanks for providing it!

wayland76’s picture

Working for me on my site.

rmiddle’s picture

Status: Reviewed & tested by the community » Fixed

Released 6.x-1.0

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.