Closed (fixed)
Project:
Similar By Terms
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Feb 2008 at 14:14 UTC
Updated:
3 Jul 2008 at 18:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
BarisW commentedSubscribing.
Would love to have the 6.x version!
Comment #2
dennys commentedSubscribing
Comment #3
zilla commentedwould love to see this in d6, wish i could write code, dammit...
Comment #4
draeton commentedThis is my first attempted patch, but I've got Similar by Terms working in Drupal 6.
Comment #5
jjeff commenteddraeton,
Looks great! However, I think you got a few (if not all) of your diff commands backwards, so instead of the new stuff showing "+", it shows "-". Your patch won't apply because it's actually saying to remove the code that you're adding and add the code that you're removing. :-)
But looking at things without actually testing things yet, it looks pretty good. I think you want to just switch the first and second arguments of the diff command that you're entering and you should be all set.
You've got:
diff -upN newfile oldfileand it should be:
diff -upN oldfile newfileComment #6
draeton commentedSee attached. I think I've got it right, this time.
Comment #7
designerbrent commentedSubscribe
Comment #8
rmiddle commentedPatch still doesn't apply for me. I went thought and manually made the changes. I get the following error tiring the patch.
Fatal error: Call to undefined function theme_similarterms() in /home/aapoliti/www/d6/sites/all/modules/similarterms/similarterms.module on line 68
Comment #9
encho commentedsubscribing
Comment #10
greenskunkSubscribing
Comment #11
designerbrent commentedThis patch applied fine for me and seems to be working as desired.
Comment #12
rmiddle commentedI couldn't get that patch to apply cleanly. I figured out that it was created under the wrong folder structure. I manually applied the patch but the following two lines wouldn't work for me and I can't confirm that they should have worked after moving of the theme function to a template file.
$block['content'] = theme_similarterms(similarterms_list());
and
$block['content'] = theme_similarterms(similarterms_list($delta));
wouldn't work so I changed them to
$block['content'] = theme('similarterms', similarterms_list());
$block['content'] = theme('similarterms', similarterms_list($delta));
and the module started to work. I am not sure why it didn't work in my test 6 environment but did work in the other two environments but based on the way core handles this I am guessing this is closers to the standard.
Thanks
Robert
Attached is my patch and a full archive of all 5 files.
Comment #13
rmiddle commentedComment #14
designerbrent commentedRobert,
This patch applied cleanly for me and appears to work fine.
Comment #15
Rob T commentedTHe attached tar.gx module provided in #12 worked for me, but I am unable to get the block configuration changes to stick. Even though I've changed the "Item count" to 15, the block still only displays 5 items.
Comment #16
rmiddle commentedOK I see it. The item count changes but doesn't apply to the number displayed. I will take a look at that this weekend.
Thanks
Robert
Comment #17
rmiddle commentedOk here is the updated patch that makes use of that variable. Hopeful between the two of us who have worked on this patch. Hopefully we haven't missed anything.
Thanks
Robert
Comment #18
Rob T commentedYup... Item Count in the block configuration works now. Thanks so much.
Comment #19
Anonymous (not verified) commentedThe patched version works for me. Thanks for providing it!
Comment #20
wayland76 commentedWorking for me on my site.
Comment #21
rmiddle commentedReleased 6.x-1.0
Comment #22
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.