Change {dblog}.type VARCHAR limit from 16 to 64

Marked #342709: Improve documentation for watchdog() as a duplicate of this issue. This seems to be an occasionally recurring problem:
#330844: Data too long
#312624: Odd Bug When Executing Action
#341229: Data too long for column 'type'

I don't see any downside to increasing the type character limit to 32. It seems to be a problem not many developers know about, especially since the limit is not documented in watchdog(). We should at a minimum improve the documentation for this problem.

Initial patch to increase the length of the {dblog}.type field. Added documentation to watchdog() and dblog_watchdog().

Is there any reason to limit it to 32? I'm sure that long module names combined with suffixes will come close to exceeding this limit. A length of 64 might be more appropriate, I think.

If we're going to increase it, might as well go to 64.

Revised patch with the 64-char limit. While browsing through hook_watchdog and implementations of hook_watchdog, I found lots of inconsistencies and errors, most notably, the drupal_mail() in hook_watchdog was the D5-version of the function. :)

Testing slave #8 failure.

Patch looks good to me. Good catch on drupal_mail(). Further proof that it would be really useful to have some functionality that allows us to test drupal_mail() calls ...

Let's extend it to 64 or 128. There is no penalty in MySQL or PostgreSQL for simply having longer VARCHAR columns unless you're hitting maximum index or row length caps.

There are plenty of reasons we wouldn't want to be merely limited to the module name for the type.

The patch in #5 actually changes it to 64. Setting back to CNR so I can double check that it still passes with the testing bot.

Ran my own tests, and everything succeeded. Code looked good too, so committed to CVS HEAD. Thanks Dave.

Hi,

I got here from Data too long for column 'link' in watchdog table which has been flaged as a dup of this issue.

Truncating the link column will prevent the warning about "Data too long" from showing up, but it also makes watchdog less useful because you won't know which *exact link* causes the log entry. If there's no penalty in having a longer varchar column in the database, why not also increase the size to, say, 2000. Just kidding; but something longer than 255.

If some clever chap could port this back to 6.17 that would be great.

Attempted:

I realized, as soon as I did that, I was working from the wrong patch. I assumed it would need additional work, did I miss anything else? The additional changes in #5 apply to D7?

Please anyone, could we have a drupal 6.x version of this patch?

@NancyDru, hmm, I don't know, perhaps someone w/more knowledge will comment? Also, curious, when do you use drupal_substr as opposed to substr?
As I was going through the API, I found a comment also referring to having this patched, although for the life of me, I cannot find it again...maybe it was nimi...
So, I redid it with #19 suggestions and higher powers can decide if it will be accepted.

+function dblog_update_6001() {
+   db_add_index($ret, 'watchdog', 'uid', array('uid'));
+   return $ret;
+ }

What's this about? I didn't see it in the D7 patch and it seems to be a mistake.