This patch adds an else statement to warn the user if the security question hasn't been answered. It also provides a status message for the user to contact the administrator if the security question does not have a value.

CommentFileSizeAuthor
#1 user_warning.patch2.28 KBfmitchell
user_warning.patch1.64 KBfmitchell

Comments

fmitchell’s picture

StatusFileSize
new2.28 KB

Fixed a bug in my patch.

Zen’s picture

What is this for? To cater for sites with existing users who haven't previously set their password_reset question? Would it not be better to force them to do it by redirecting them to the user edit page until they have done so?

What is the query change in your patch for?

Thanks,
-K

Zen’s picture

Status: Needs review » Postponed (maintainer needs more info)
fmitchell’s picture

Status: Postponed (maintainer needs more info) » Needs review

This is correct.

If one implements this module after having a set list of users or importing users from an upgrade or multi-site integration, having the warning is needed. Forcing users to do something, I think, is poor usability.

Zen’s picture

Status: Needs review » Needs work

Seeing as to how this module forces this process on new users, I don't see this as being unusable. I'd personally find the nag message or as an admin, lots of reset requests, a lot more annoying.

Why the query change? Please also check your patch for coding standards issues ...

-K

sanduhrs’s picture

As far as I can see,
* existing user accounts get initialised with question number 1 and a hash value generated from the user's password and some salt.
* New users have to choose a question and a answer, when they sign up.

Nontheless, using modules like ucreate [1] produces users without question/answer, and creating users via ?q=admin/user/user/create produces users with questions and answers they probably don't know about.

I think a possible way to go could be
* Do not initialize existing users with q/a they don't know
* Instead _force_ them to choose a q/a after their next/first login
* Display a message above the request password q/a form to contact the administrator (optional contact form) if the answer is unknown

Any thoughts?

[1] http://drupal.org/project/ucreate

Zen’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs work » Fixed

Redirect + Message feature added.

Cheers,
-K

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.