Your module has 'administer og content types' access type. So, It would be perfect if module show it's tab on the group page to user who has this permission but not someone else. I've made changes and created patch. It's in attach.

CommentFileSizeAuthor
og_content_type_admin.patch486 bytesneochief

Comments

rconstantine’s picture

rconstantine commented
Status: Needs review » Closed (works as designed)

It would appear you missed this code, just before the lines in your patch:
if (_og_content_type_admin_is_admin($group)) {
which takes care of permissions. Your patch requires that users be assigned a role which means that in 'normal' installs where all users can create groups, those users would not be able to maintain their own group's content types unless assigned this role. Alternatively, you saw the line I quoted but in your installations must want a double redundancy or something. I don't think that is appropriate for the general uses of this module, so I won't be adding your change. As that menu item now stands, only site admins and group owners should be seeing the tab. It works fine in all of my installs.

neochief’s picture

neochief commented
Status: Closed (works as designed) » Closed (fixed)

Oh, I found the great checkbox "Disallow changes by all group owners" that I missed before in settings of the module. Thanks, I really did the empty work.