Usability: Admin/block warning message placement
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | block.module |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
I'm not sure this is the correct place for this, but the warning message on the "admin/build/block" page should be at the top of the table of blocks, not at the bottom just above the button. I watched as one of my admins spent a bit of time rearranging blocks and then tried to configure one only to find out that his previous work was wiped out because he didn't see the warning message until he made the mistake THEN went to click submit after rearranging the blocks a second time. Besides, it seems like the drupal convention for other such warning messages is to present them at the top of the screen.
Attached is a patch for this-- it actually patches the tabledrag.js file so it can potentially affect more than just this module, but I can't think of a single case where you wouldn't want the warning displayed more prominently at the top. Another option is to display it twice-- bottom and top. If this is desirable let me know and I'll reroll.
Also, this is my first core patch, any comments / corrections welcome.
| Attachment | Size |
|---|---|
| tabledrag.js_.patch | 526 bytes |
#1
forgot to update status to PNR.
#2
renaming to a more meaningful title ;)
#3
Being picky.
#4
Terminal couldn't find the file to patch on mine... I'm not sure if that's my fault or the patch's.
#5
Okay, had to ask a dumb question to figure that one out, but you didn't roll it from root. Anyway, I really like this patch. Huge +2, why would we have it at the bottom?
The only better placement I could think of would be next to the block area that you moved a block to- but I imagine that would be a bit tricky.
I want to mark this RTBC- however, it should be noted that I didn't review the code.
#6
I just checked the code, and it's a simple enough change, so marking RTBC.
#7
Duh... sorry about not rolling from root, my brain spasm. The other code shouldn't have changed at all... i only needed to change one jquery command-- shouldn't have affected anything else.
#8
No problem, I like this patch and it's your first one anyways.
#9
I suggest changing the background color or border of the whole blocks table. Whether the warning is at the top or bottom, it's not easy to see at a glance that the page has unsaved changes.
For example, the background of the blocks table could be changed to the faint red that goes with unpublished nodes - seems to fit, in a way.
I also suggest prompting the user to save changes on exit. Google mail and many other AJAX applications do this.
#10
Committed to CVS HEAD. Thanks.
#11
Automatically closed -- issue fixed for two weeks with no activity.