This patch addresses a few issues:

1)Block configuration via the UI was not always giving predictable results. There were a few variable name that did not match. While I was at it the macro values from the block config via the UI are now merged with the gmap defaults. So if you do not specify any special macros in the block configs you will get the default map.

2)No labels aka tool tips when mousing over in either block. The node block now uses the "Location name" field and the author block should return the..err..well..author when you hover over the marker. Was not previously implemented for node block and we had the wrong syntax in the author block.

3)I tried to force the node block map to center on lat/long if only a single marker. Sorry no luck. It can be done I am sure but I am out of juice for the day.

4)Probably some other small stuff I have forgotten about...

This patch is a diff from the 2007-12-30 gmap_location.module so it should cover both the alpha and the dev versions by the looks of it. This is only my second patch for Drupal so feedback can only make me smarter - I hope.

CommentFileSizeAuthor
#2 gmap_location_module_v2.patch3.73 KBcglusky
gmap_location_module.patch3.47 KBcglusky

Comments

cglusky’s picture

cglusky commented

see, i knew i forgot something. i started working own this patch today because the map controls would not show even when you told them to. that had to do with some hard coded configs that have been replaced with a merge with defaults. so you should have your controls and other things back on the block maps if you say they should be there.

cglusky’s picture

cglusky commented
StatusFileSize
new gmap_location_module_v2.patch3.73 KB

Ok this is version two with a bit of code from smitty.

1)It will now show tool tips with location name if specified and if not use node title. location name handy if you are allowing multiple locations in a node.

2)The maps will now center if you are displaying one marker per block - without autozoom. ONLY WORKS IF you have "None" selected for marker manager in GMap Admin. Tested with Google's manager and it didn't seem to like my efforts to set the center of the map. Perhaps a bug? Did not test with cluster.js There is also an issue if you want autozoom to center a node block with multiple markers - It works but you will also get autozoom with any block that has a single marker, which tends to zoom in a bunch. I bring this up because autozoom is going to override your zoom. So, if you are only allowing a single marker per node block then I would turn autozoom off in the macro, so your zoom setting is respected. If you are allowing multiple markers per node block you will have to decide if you like autozoom and center better than a tight view on a single marker node block.

A BIT ABOUT MACROS with this patch applied - if you set ANY "behavior" values in your macro you will not get defaults behaviors to merge. So in other words, if you say behavior=+nocontrol you will also loose autozoom etc even if they are part of the default settings in GMap Admin. A bit confusing, but just make sure that if you want to be accurate be explicit in setting all preferred "behaviors" in your macro. If you do not specify any behaviors in your macro then all the default behaviors will be used. Bug or feature - not sure yet. This only applies to the "behavior" settings. E.g. You can use a macro as simple as [height=200] and the gmap defaults will all be used except you will override your default height.

bdragon’s picture

bdragon commented
Status: Needs review » Fixed

I fixed the outstanding issues with the blocks. (@#2: The other things you mentioned are seperate issues. I *think* they're fixed too, but at the very least they already have their own issue #s.)

http://drupal.org/cvs?commit=166426
http://drupal.org/cvs?commit=166429

cglusky’s picture

cglusky commented

Thanks bdragon! I have since moved to D6, and have not had a chance to play with much geo stuff. Stuck in two way email integration hell.

Hope some of this helped.

R,
Coby

bdragon’s picture

bdragon commented

Well, what I do with one, I do with the other. Equivilent changes were made in both branches. Good luck with that email integration!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.