Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
See #2223189: Use regular upstream HttpKernel instead of Drupal's custom
Proposed resolution
Instead of injecting request
service, rather use router.request_context
in PathBasedBreadcrumbBuilder
.
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#6 | 2236207-use-router-request-context-in-system-breadcrumb-builder-6.diff | 8.74 KB | znerol |
#1 | 2236207-use-router-request-context-in-system-breadcrumb-builder.diff | 8.69 KB | znerol |
Comments
Comment #1
znerol CreditAttribution: znerol commentedComment #2
znerol CreditAttribution: znerol commentedComment #4
znerol CreditAttribution: znerol commented1: 2236207-use-router-request-context-in-system-breadcrumb-builder.diff queued for re-testing.
Comment #6
znerol CreditAttribution: znerol commentedReroll.
Comment #7
dawehnerInteresting. In contrast to the url generator the usecases are certainly more limited but yeah, why not.
Comment #9
znerol CreditAttribution: znerol commented6: 2236207-use-router-request-context-in-system-breadcrumb-builder-6.diff queued for re-testing.
Comment #10
dawehnerThat is fine
Comment #11
alexpottCommitted b4dba2b and pushed to 8.x. Thanks!