Problem/Motivation

See #2223189: Use regular upstream HttpKernel instead of Drupal's custom

Proposed resolution

Instead of injecting request service, rather use router.request_context in PathBasedBreadcrumbBuilder.

Remaining tasks

User interface changes

API changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

znerol’s picture

znerol’s picture

Status: Needs review » Needs work
znerol’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work
znerol’s picture

Status: Needs work » Needs review
FileSize
8.74 KB

Reroll.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Interesting. In contrast to the url generator the usecases are certainly more limited but yeah, why not.

Status: Reviewed & tested by the community » Needs work
znerol’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

That is fine

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed b4dba2b and pushed to 8.x. Thanks!

  • Commit b4dba2b on 8.x by alexpott:
    Issue #2236207 by znerol: Use router request context instead of request...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.