Problem/Motivation

See #2223189: Use regular upstream HttpKernel instead of Drupal's custom

Proposed resolution

Instead of injecting request service, rather use router.request_context in PathBasedBreadcrumbBuilder.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 2236207-use-router-request-context-in-system-breadcrumb-builder-6.diff8.74 KBznerol
#1 2236207-use-router-request-context-in-system-breadcrumb-builder.diff8.69 KBznerol

Comments

znerol’s picture

znerol commented
Status: Active » Needs review
Related issues: +#2223189: Use regular upstream HttpKernel instead of Drupal's custom
StatusFileSize
new 2236207-use-router-request-context-in-system-breadcrumb-builder.diff8.69 KB
znerol’s picture

znerol commented
Parent issue: » #2223189: Use regular upstream HttpKernel instead of Drupal's custom
Related issues: -#2223189: Use regular upstream HttpKernel instead of Drupal's custom

Status: Needs review » Needs work

The last submitted patch, 1: 2236207-use-router-request-context-in-system-breadcrumb-builder.diff, failed testing.

znerol’s picture

znerol commented
Status: Needs work » Needs review

1: 2236207-use-router-request-context-in-system-breadcrumb-builder.diff queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: 2236207-use-router-request-context-in-system-breadcrumb-builder.diff, failed testing.

znerol’s picture

znerol commented
Status: Needs work » Needs review
StatusFileSize
new 2236207-use-router-request-context-in-system-breadcrumb-builder-6.diff8.74 KB

Reroll.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Interesting. In contrast to the url generator the usecases are certainly more limited but yeah, why not.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 2236207-use-router-request-context-in-system-breadcrumb-builder-6.diff, failed testing.

znerol’s picture

znerol commented
Status: Needs work » Needs review

6: 2236207-use-router-request-context-in-system-breadcrumb-builder-6.diff queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

That is fine

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed b4dba2b and pushed to 8.x. Thanks!

  • Commit b4dba2b on 8.x by alexpott: 
    Issue #2236207 by znerol: Use router request context instead of request...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.