Please review the patch for Drupal core
ahoeben - February 19, 2008 - 09:04
| Project: | Re: Comment subjects |
| Version: | 5.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
I planned to have the functionality of this module included in Drupal core for 6.x. Unfortunately that did not happen because my patch did not get reviewed. Please don't let this happen for Drupal 7.x. Review my core patch!

#1
#2
may I ask, why core if it's performing so well as module?
#3
Because the current subject field behavior leads to unwanted visitor behavior and/or useless comment subjects:
"Technically speaking the subject of most comments will be the post itself. So the comment subject line often ends up being something like, "Agreed" or "Another thought", which doesn't really mean much. However the comment subject line is used in the comment block and several other places in Drupal where comments are listed. If it is not enabled, Drupal will use the first few words of the post as the subject line." (from a Lullabot article).
So in my view, and that of others, the current behavior of comment.module is flawed.
#4
well, comment_subject didn't make it for D7,
nevertheless, I guess there will still be issues regarding comment subjects defaults in D7
so probably we might push for D8,
but in that case a reorganization/reroll should be prepared to persuade Dries to change his mind (http://drupal.org/node/138632#comment-991345)
I guess that having more flexible/configurable default subjects might help
for now I'm closing this issue, since it is the oldest active
please reopen if you feel it deserves (or open a new one once D7 has been criticized about this)
#5
as an interesting note before re-attempting to get comment_subject into core
http://drupal.org/node/6465#comment-296766
dated March 14, 2004
it reads: