all broadcasts are being sent as site owner

thanks for looking into this...but I don't know WHERE I put this patch? What file? Does it replace some lines?

thanks....I don't feel comfortable running command line commands....is there another way to make it happen?

by chance is this worked into a signup.module update yet?

sorry to cause your frustration.

I have made slight modifications to the signup.module so I got an error when trying to run the patch (I tried to learn!!!). I'm assuming it's looking for similarly (proper) coded lines to rewrite and since I've added some lines, it doesn't match up.

Is that an accurate statement? This is the first patch I've tried to run.

I also tried to do it manually

I replaced/removed this line:
- $from = $form_values['from'];

And added these in it's place:
+ if (user_access('administer site configuration')) {
+ $from = $form_values['from'];
+ }
+ else {
+ global $user;
+ $from = $user->mail;
+ }

But it had no effect.

Thanks for your advice (if you have any more) and if not, I'll have to wait for an updated module someday.

Thanks for this great module too - it's the core of this site I'm doing.

I reviewed the changes I made and it is all good (should be)...but it isn't.

It's even stranger than I thought.

When I send broadcast emails from the admin user (UID=1), it sends it from that user's email address (working properly).

But when I send broadcast emails from a user that owns that event node, it sends it from the email address I have as the site's email address (set at /admin/settings/site-information)...even tho when that user is on their /node/xxx/signup-broadcast page, it does say that it will be sent from their email address.

I've attached my signup.module file here in hopes you could review the changes I made (at line 2333).

I'd REALLY appreciate help with this.

pretty please?! :) I could still use some help on this.

I hate to open up this ticket after all this time but I still can't get this fixed and I can't apply the patch due to some custom code added elsewhere in that file.

Here is my section for getting the node-owner's email address as the sent-from person:

/**
 * Send an email message to all those signed up to an event.
 *
 * @param $form_id
 * @param $form_values
 */
function signup_broadcast_form_submit($form_id, $form_values)
{
	$addresses=signup_get_email_addresses($form_values['nid']);

	if (is_array($addresses))
	{
		if (user_access('administer site configuration')) {
			$from=$form_values['from'];
			}
		else
		{
			global $user;
			$from=$user->mail;
		}

		$subject=$form_values['subject'];
		$event=node_load($form_values['nid']);
		foreach ($addresses as $signup) {
			$mail_address=$signup->anon_mail ? $signup->anon_mail : $signup->mail;
			$trans=array(
				'%event'=>$event->title,
				'%username'=>$signup->uid ? $signup->name : variable_get('anonymous', t('Anonymous')),
				'%useremail'=>$mail_address,
//        '%info'=>$signup_info,
			);

			$trans['%time']=signup_format_date($event);

			$message=strtr($form_values['message'], $trans);
			drupal_mail('signup_broadcast_mail', $mail_address, $subject, $message, $from);
			watchdog('signup', t('Broadcast email for %event sent to %email.', array('%event'=>$event->title, '%email'=>$mail_address)), WATCHDOG_NOTICE, l(t('view'), 'node/'. $event->nid));
		}
	}
	drupal_set_message(t('Message sent to all users who have signed up'));
}

I've been struggling with this for over a year now and I'm hoping someone can tell me what's wrong in it.

MANY thanks.