When OpenSSL is not enabled, the associated help message doesn't show up [#224340]

Running Drupal 5.7 on Win32
I had openssl disabled in my php.ini file and couldn't get the Gmail smtp settings to work.
When looking at the source code, I discovered a handy help message that was never shown.

Here are my proposed changes to enable the display of this message:

  if (function_exists('openssl_open')){ //Only display the option if openssl is installed.
    $form['server']['smtp_protocol'] = array(
      '#type' => 'select',
      '#title' => t('Use encrypted protocol'),
      '#default_value' => variable_get('smtp_protocol', 'standard'),
      '#options' => array('standard' => t('No'), 'ssl' => t('Use SSL'), 'tls' => t('Use TLS')),
      '#description' => t('This allows connection to an SMTP server that requires SSL encryption such as gmail.'));
  }
  else{ //If openssl is not installed use normal protocol.
    variable_set('smtp_protocol', 'standard');
  	$form['server']['smtp_protocol'] = array(
      '#type' => 'select',
      '#title' => t('Use encrypted protocol'),
      '#default_value' => variable_get('smtp_protocol', 'standard'),
      '#options' => array('standard' => t('No')),
      '#description' => t('Your PHP installation does not have SSL enabled. See the !url page on php.net for more information. Gmail requires SSL.', array('!url' => l(t('OpenSSL Functions'), 'http://php.net/openssl'))),
      );
  }

Comments

Comment #1

preventingchaos commented 20 February 2008 at 15:42

or maybe something like this?

if (function_exists('openssl_open')){ //Only display the option if openssl is installed.
  $encryption_options = array('standard' => t('No'), 'ssl' => t('Use SSL'), 'tls' => t('Use TLS'));
  $encryption_description = t('This allows connection to an SMTP server that requires SSL encryption such as gmail.');
}
else{ //If openssl is not installed use normal protocol.
  variable_set('smtp_protocol', 'standard');
  $encryption_options = array('standard' => t('No'));
  $encryption_description = t('Your PHP installation does not have SSL enabled. See the !url page on php.net for more information. Gmail requires SSL.', array('!url' => l(t('OpenSSL Functions'), 'http://php.net/openssl')));
}
$form['server']['smtp_protocol'] = array(
  '#type' => 'select',
  '#title' => t('Use encrypted protocol'),
  '#default_value' => variable_get('smtp_protocol', 'standard'),
  '#options' => $encryption_options,
  '#description' => $encryption_description);