I wondered why <span> was displaying on the block heading when the mouse was moved over it. I am using the default Zen theme. When looking at the code in drupal 6.0 and drupal 5.7 I found out that the prototype of the function l (in includes/common.inc) has changed. But in the template.php of the Zen template for drupal 6 the function is called with paramters for drupal 5. Thus <span> is translated into &lt;span&gt; which is displayed as <span> and not interpreted.

Perhaps other modules, too, use the function l in that manner. You should check, if you have to change that function call.

CommentFileSizeAuthor
#2 zen_block_hover_fix_2.patch3.48 KBAragorn450
#1 224416_1_zen_block_hover_fix.patch3.57 KBsykora

Comments

sykora’s picture

sykora commented
Title: <span> displaying on mouse over on block heading » Incorrect arguments to l() -- <span> displaying on mouse over on block heading
Status: Active » Needs review
StatusFileSize
new 224416_1_zen_block_hover_fix.patch3.57 KB

Yes, the args to l() have changed. You did all the work, I hardly did a thing :)

This is my first contributed patch, so be nice :) . Criticism is appreciated, though.

Aragorn450’s picture

Aragorn450 commented
StatusFileSize
new zen_block_hover_fix_2.patch3.48 KB

I modified your patch slightly. There were a couple of trailing commas in a few of the arrays, even though there wasn't another element in the array.

sykora’s picture

sykora commented

Um...Coding standards?

Check the part about the trailing commas.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Fixed

Actually, Sykora, your patch is missing a couple commas, as per the coding standards. :-)

I’ve committed your patch. Thanks for the help!

Also, druppi, thanks for finding the cause. It looks like there are even some incorrect l() calls in Drupal 6.0 core.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.