Converts the following forms:

  • install_configure_form
  • install_settings_form
  • install_select_profile_form
  • install_select_language_form
CommentFileSizeAuthor
#3 install-forms-2245249-3.patch48.54 KBtim.plunkett
#3 interdiff.txt823 bytestim.plunkett
#1 install-forms-2245249-1.patch48.17 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new install-forms-2245249-1.patch48.17 KB

Copied build/validate/submit
Changed t() to $this->t()
Used DI where appropriate.
Minor modernizations to install_get_form.

Status: Needs review » Needs work

The last submitted patch, 1: install-forms-2245249-1.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt823 bytes
new install-forms-2245249-3.patch48.54 KB

We need to work around drush, but using the actual form ID and not the class name fixes it, and is more correct.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Normal » Major
Related issues: +#1530756: [meta] Use a proper kernel for the installer

Straightforward.

I'd like to improve the situation some more, but that's more complex, so I'd like to RTBC + move forward with this change ASAP.

Thanks, @tim.plunkett!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Related issues: +#2234315: Dependency graph resolved plugins for installer tasks
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Excellent.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Really nice clean-up.

Committed and pushed to 8.x. Thanks!

  • Commit 16f07ea on 8.x by webchick: 
    Issue #2245249 by tim.plunkett: Convert installer forms to FormInterface...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.