This patch is, by far, thanks to Code Review. Apart from the code review's suggestions, I've added a newline and removed a superfluous space in a text string (as is the de facto standard of core strings).

CommentFileSizeAuthor
#2 cram.d6.misc_cleanup.patch2.5 KBFreso
cram.install.d6.code_review.patch2.64 KBFreso
cram.install.d5.code_review.patch3.21 KBFreso

Comments

selmanj’s picture

selmanj commented
Status: Needs review » Fixed

Committed and fixed. Thanks.

Freso’s picture

Freso commented
Status: Fixed » Needs review
StatusFileSize
new cram.d6.misc_cleanup.patch2.5 KB

Here's a wee bit more. This time, it's mostly comments being properly capitalised (one is rephrased), as well as an alignment issue. I originally had this combined with the "no file path" patch, but decided against it, as this is even more minor than that one...

Freso’s picture

Freso commented
Version: 5.x-1.x-dev » 6.x-1.x-dev

That patch is for D6, btw, should be trivial to port, but I'm deep in 6.x right now.

selmanj’s picture

selmanj commented
Status: Needs review » Needs work

Looks good to me. Waiting for a D5 patch before commiting.

Freso’s picture

Freso commented
Status: Needs work » Fixed

Committed a slightly modified version of the patch for both branches.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.