When performing .../update.php, during the stage of "select updates" (in .../update.php?op=selection), I get 2 warnings:

warning: in_array() [function.in-array]: Wrong datatype for second argument in .../sites/all/modules/journal/journal.module on line 72.

warning: array_unshift() [function.array-unshift]: The first argument should be an array in .../sites/all/modules/journal/journal.module on line 85.
CommentFileSizeAuthor
#6 journal-DRUPAL-6--1.patch866 bytessun
#4 journal-DRUPAL-6--1.submit-warning.patch1.61 KBsun
#1 journal.update.patch1.2 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Wrong datatype... » update_script_selection_form missing in skipped form_ids
Component: Code » Forms
Assigned: Unassigned » sun
Status: Active » Fixed
StatusFileSize
new journal.update.patch1.2 KB

Thanks, committed attached patch to fix this bug.

drdrup’s picture

drdrup commented

I've tried the patch. The problem is gone.

Thanks!!

drdrup’s picture

drdrup commented
Status: Fixed » Active

(Sorry to open this issue again, but I thought it is better than opening a new one)

I just installed "CSS injector" module, and those same 2 warnings appear.

Does it mean that more entries have to be added to the journal_skip_form?

What special about the CSS injector form that cause this problem? It looks like any other module. So why shouldn't it be "worthy" of a journal entry?

or is there something else that "journal" should check, or adjust for?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed
StatusFileSize
new journal-DRUPAL-6--1.submit-warning.patch1.61 KB

I've reverted the previous fix and implemented a real one.

drdrup’s picture

drdrup commented
Status: Fixed » Active

I applied patch #4.
When going to update.php (the second step)

I got:

warning: array_unshift() [function.array-unshift]: The first argument should be an array in /.../sites/all/modules/journal/journal.module on line 85.
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Fixed
StatusFileSize
new journal-DRUPAL-6--1.patch866 bytes

Sorry, my fault.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

LindenLion’s picture

LindenLion commented
Title: update_script_selection_form missing in skipped form_ids » warning: The argument should be an array (...) line 258
Version: 6.x-1.0 » 6.x-1.1
Component: Forms » Code
Priority: Normal » Critical
Status: Closed (fixed) » Active

Hi, just installed journal and logged some journal entries. No error message, till: I went to /admin/reports/journal to view my journal entries, but found:

warning: array_shift() [function.array-shift]: The argument should be an array in /home/.saul/them/them.lindenlion.net/sites/all/modules/journal/journal.module on line 258.

Hope you can fix it :-D

edward.peters’s picture

edward.peters commented

Same issue for me. Can someone help please?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)

I am unable to replicate this bug using the latest development snapshot. Could you please verify?

edward.peters’s picture

edward.peters commented

I have tested latest dev version and all works brilliantly. Thanks so much for fixing this!

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Postponed (maintainer needs more info) » Fixed
Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

okeedoak’s picture

okeedoak commented
Status: Closed (fixed) » Active

On a new D6 site no problems. On a D5 site upgraded to D6 even after disabling, uninstalling, and re-enabling the module on every page there is an error:
warning: array_shift() [function.array-shift]: The argument should be an array in .../journal/journal.module on line 244.

On /admin/reports/journal there are two errors of the same array_shift problem: the original line 244 and line 258.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Please update to the latest development snapshot and report back whether you still encounter the error messages. If not, I'll release a new stable afterwards.

okeedoak’s picture

okeedoak commented

Yes, the latest dev version fixes both error messages. Thank you. Time for a new release?

okeedoak’s picture

okeedoak commented
Status: Active » Closed (fixed)
sun’s picture

sun
Primary language German
Location Karlsruhe
commented

A new release is available now.