This "view phpinfo form the status page" feature has been in two versions of Drupal now, and I've totally missed it. Have you missed it too?

See attached screenshot. To get to these pages, you need to click on the *version numbers* of PHP/MySQL. I always knew those were links but it never occurred to me that clicking on them would get me the pages that they do.

The first rule of links is they should be descriptive as to where they go. I'd recommend doing something more like:

PHP : x.x.x (more information)
MySQL: x.x.x (more information)

Comments

kbahey’s picture

+1 for this. I missed them too, and create a phpinfo.php when needed.

keith.smith’s picture

I found those links quite by accident some time ago -- or actually, now that I think about it, I think I may have heard chx make some comment in #drupal about the built-in phpinfo() and went looking for it.

The only small gripe I have with putting additional text here -- and it is only a very very small gripe -- is that people sometimes copy-and-paste the info in this table into various posts, and and additional text would then be in the middle of that. We even have "It may be useful to copy and paste this information into support requests filed on drupal.org's support forums and project issue queues." at the top of that page.

nancydru’s picture

@keith: I understand that gripe, but it's also common practice to include an "ops" column for things like this, as well as "run cron manually", etc.

@angie: I found it only after I added similar functionality to Sitedoc... ;-)

eMPee584’s picture

++
imho phpinfo deserves it's own menu entry but I've heard devel has something like that. Gotta check it out... but more severe is that the phpinfo call does exclude a lot of useful information because it is called with INFO_GENERAL | INFO_CONFIGURATION instead of INFO_ALL...

christefano’s picture

Status: Active » Needs review
StatusFileSize
new2.07 KB
new9.75 KB

Here's a patch that implements more visible "more information" links.

catch’s picture

Status: Needs review » Needs work

I always forget these are there, so +1 to making them more obvious. I'm wondering if the PHP link should mention phpinfo() specifically to make it really obvious where it goes - otherwise it could look like "more information about PHP 5.2.1. Maybe.

Patch has a commented line in it which needs taking out.

christefano’s picture

Status: Needs work » Needs review
StatusFileSize
new1.79 KB

This one removes the commented line.

keith.smith’s picture

Status: Needs review » Needs work

Note that there are some minor code style violations in the patch (spacing around concatenation operators and string literals).

christefano’s picture

StatusFileSize
new1.78 KB

This corrects the spacing around the concatenators and strings.

christefano’s picture

Status: Needs work » Needs review

Have we settled on the wording for this? The patch more or less implements webchick's proposed wording (as seen in the screengrab at http://drupal.org/files/issues/status_more_links.png), which is good enough for me.

nancydru’s picture

works for me

Zothos’s picture

Be carefull. We have to check if phpinfo is disabled via the php.ini
maybe function_exists would help. Ill test it

christefano’s picture

@Zothos, that's a really good point. This patch tests for that and displays a message if phpinfo() is disabled. It's a REQUIREMENTS_INFO message instead of a REQUIREMENTS_WARNING so that it won't appear during installation.

I also added a handbook page at http://drupal.org/node/243993 that explains why phpinfo() may be disabled (and what to do about it) and added a link to it in the message.

sutharsan’s picture

Component: user interface text » usability
lilou’s picture

Status: Needs review » Needs work

Patch #13 no longer applies.

yoroy’s picture

Title: Usability: Make phpinfo()/MySQL info links more obvious » Make phpinfo()/MySQL info links more obvious

I'd like to see this get fixed quickly, can somebody reroll please

lambic’s picture

Component: usability » base system
Status: Needs work » Needs review
StatusFileSize
new1.72 KB

database stuff isn't on status report any more, so I've rerolled with just the phpinfo() additions

nancydru’s picture

Status: Needs review » Needs work

No: "} else {" - coding standards violation.

lambic’s picture

Status: Needs work » Needs review
StatusFileSize
new1.73 KB

else fixed

yoroy’s picture

StatusFileSize
new1.71 KB

Slight rewording making it a bit shorter:
"has been disabled" -> "is disabled"
Don't use please (http://drupal.org/node/501452) and put the main message (the handbook link) first:
Read the handbook page for more information.

chx’s picture

I know it's not strictly belongs this patch but if you are meddling with this, could you please save phpversion into a variable and use it throughout? It's an eyesore to see so many needless function calls. (There is at least one after the block of code you use)

nancydru’s picture

+1 Why not make it a global so everyone can access it?

lambic’s picture

StatusFileSize
new1.82 KB

Making it a global seems like overkill to me, but I've variablised it locally in the attached patch

eMPee584’s picture

Status: Needs review » Reviewed & tested by the community

Looks good!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Nice! Committed to HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.