Split up openid and openid2 links
Quintasan - February 21, 2008 - 10:08
| Project: | OpenID URL |
| Version: | 5.x-1.x-dev |
| Component: | Miscellaneous |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Rob Loach |
| Status: | patch (to be ported) |
Description
I noticed that Drupal module OpenID doesn't recognize openid.pl domain
#1
OpenID URL implements both OpenID 1 and 2 specs, so I'm not sure what's wrong. In the very least, try updating to a later version of the module.
#2
Could you try it again? I just put in a patch that switches the attributes around... http://drupal.org/node/229877
#3
Some hosts, like sourceforge, don't support having the two links listed in the same variable, so we should split them up.
<link rel="openid.server" href="http://pip.verisignlabs.com/server" /><link rel="openid.delegate" href="http://username.pip.verisignlabs.com/" />
<link rel="openid2.provider" href="http://pip.verisignlabs.com/server" />
<link rel="openid2.local_id" href="http://username.pip.verisignlabs.com/" />
#4
I use phpMyID which only supports OpenID 1.1 (AFAIK) and run into some problems.
Removing
openid2.providerandopenid2.local_idin/sites/all/modules/openidurl/openidurl.modulesolved it for me.Maybe you can add a selection, which OpenID-HTML-Headers get included.
For example:
Include following HTML-Headers (make sure which standard your provider supports):[X] OpenID 1.0
[X] OpenID 1.1
[ ] OpenID 2.0
#5
Great idea, Inte.
#6
I'll hit it up today. Mind testing 6.x-1.x-dev once it's in? I'd like to do a release sooner then later.
#7
Actually, could you test this with 6.x-1.x-dev now? It already splits the parameters into two different link tags instead of sticking them in the same parameter.....
<?phpdrupal_set_html_head('<link rel="openid.server" href="'. check_url($server) .'" />');
drupal_set_html_head('<link rel="openid.delegate" href="'. check_url($delegate) .'" />');
drupal_set_html_head('<link rel="openid2.provider" href="'. check_url($server) .'" />');
drupal_set_html_head('<link rel="openid2.local_id" href="'. check_url($delegate) .'" />');
?>
If that works for you, I'll make a release.....
#8
............ Dev should be good..... If not, this'll do it.
#9
After some testing on SourceForge, it still seems to be a problem, so I committed this.
http://drupal.org/cvs?commit=139652
#10
If anyone wants this in the Drupal 5 branch, feel free to send in a patch.
#11
I checked the OpenID 1.1 settings as phpMyID doesn't support OpenID 2.0
It does it's job ... nothing more and nothing less. ;) Thanks for your work.
Maybe someone with a 1.1 & 2.0 compatible provider should run a check including both parameters, before you release a stable version (which I'm waiting for).