file_check_upload() merged into file_save_upload() and there are new parameters for file_save_upload(). These are not caught by Coder.

CommentFileSizeAuthor
#1 coder_224970.patch2.34 KBstella

Comments

stella’s picture

Status: Active » Fixed
StatusFileSize
new2.34 KB

Try the attached patch or the latest version from CVS.

Cheers,
Stella

nancydru’s picture

Okay, it will take a bit because I have now fixed the code, so I will have to "unfix" it.

nancydru’s picture

I haven't had a chance to test this, but there is another wrinkle here. I don't know if it can be handled by Coder or not.

In D6, files now have a status. By default, the uploaded file is considered temporary and will be deleted on the next cron run after 24 hrs. So, if there is a file_save_upload and the same function does not include file_set_status($file, FILE_STATUS_PERMANENT);, it would be nice to issue a warning that the file may be deleted as a temporary file.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.