Be gentle. First time I've submitted a patch. ;o)

It's time to get this great module upgrade and ready for Drupal 6. The attached patches allow the module to be installed on a Drupal 6 installation and to the best of my knowledge, everything is working exception the Jump feature. I'll keep looking at that.

Seeing that this is my first patch, I'd really appreciate peer review and feedback. I really like this module and want to contribute back my attempt at getting it working on on of my sites.

Thanks and Blessings.

CommentFileSizeAuthor
#1 search404.module.patch10.33 KBtech4him
#1 search404.install.patch1.3 KBtech4him
#1 search404.info_.patch581 bytestech4him
search404.info_.patch582 bytestech4him
search404.install.patch1.3 KBtech4him
search404.module.patch10.13 KBtech4him

Comments

tech4him’s picture

tech4him commented
StatusFileSize
new search404.info_.patch581 bytes
new search404.install.patch1.3 KB
new search404.module.patch10.33 KB

Okay. Here are the revised patches. The Jump to option is working. (Duh, needed to turn off the Theme Developer piece of the Devel module)

I also modified the "Evil Haxx" section. The module now redirects the user to the search module with the specific keys for the node type. This allows the full page rendering to take place. This resolves the issue of blocks not appearing as stated in issue #217826: Missing left menu column

I actually prefer this method of using the core search module rather than simply trying to replicate its functionality. Others may disagree. The special page not found messaging still works when displayed in the search results.

Hope this helps get us close to Drupal 6 for Search404.

w98’s picture

w98 commented

These patches are for an older version of the code than is available for download, so all three patch files fail.

Can you update them for the latest downloadable versions, or release a v6-dev version?

tech4him’s picture

tech4him commented
Status: Needs work » Closed (fixed)

Looks like zyxware got the V6 update done. Thanks. At least we tried. ;)

zyxware’s picture

zyxware commented

t4hi - Thanks for your help. We have used your patches to base the upgrade to D6 :).