I had an annoying problem withe the chat window no scrolling properly when the window got full. This only happened in IE7. I discovered that this only happened if the body field was blank on the page that held the phpfreechat. If I entered something in this field (even  ), then the scrolling worked as expected.

Comments

permutations’s picture

I had this problem, too. I have text in the "body" portion of the page, and it still happened.

permutations’s picture

More on this problem...

The scrolling problem only occurs within IE7 - it's fine in Firefox - and apparently it only happens when the theme embeds the chatbox within a table. See this post:

http://www.phpfreechat.net/forum/viewtopic.php?id=1204

My theme uses tables for formatting. I guess I could rewrite it with CSS. Or better yet, I could create the chatbox in a popup. There's demo code for that with phpfreechat.

permutations’s picture

I rewrote my theme to position with CSS rather than tables, and the scrolling problem went away.

sdsheridan’s picture

hey, permutations... just want to let you know that despite not much (any?) feedback on your investigation and progress, i'm watching with keen interest. i'm not a PHP programmer, and still kind of struggle my way around CSS, so i'm hopeful that you figure the whole thing out (with hopefully some help from knowledgeable people) and then share with the rest of us. I tried to implement this module probably round RC1, and got totally frustrated with it, not able to make it work. I really want to implement a live chat feature on my site, but not if i have to go to hell and back to do it, so if you figure it out, I (and i suspect "we") are in your debt!

permutations’s picture

I have fixed almost every bug in the program. It's working fine on my site now. Here are links to what I've fixed:

Blocks bug:
http://drupal.org/node/200962

Database bug:
http://drupal.org/node/250069

To fix the scrolling bug I wrote my own theme, but there are probably other themes that don't use tables.

The one bug I haven't fixed yet is the settings page not working, but I have a pretty good idea what's wrong. I'll fix that soon.

I'm not an official developer here and I don't want to learn all the rules for packaging things up, but I'll post the fixes for someone else to package up.

It's nice to have feedback from someone, thanks!! :)

permutations’s picture

I fixed all the bugs in the phpfreechat module (a few more than are listed above), updated the module version to 5.x-1.1, and posted the full package on my Web site here:

http://permutations.com/drupal/phpfreechat.php

I emailed the original author of the module about creating a new download, but he never answered me. There were too many changes to track of as individual patches.

permutations’s picture

There's a new version with two additional fixes on my Web site (along with many other fixes):

http://permutations.com/drupal/phpfreechat.php

permutations’s picture

I have a version of the phpFreeChat module on my Web site that fixes many different bugs. I just updated it today. If owahab makes me a module maintainer here on Drupal, I'll integrate the changes here and stop posting them separately:

http://permutations.com/drupal/phpfreechat.php

owahab - please stop deleting this link. It is not helpful to the community.

permutations’s picture

I just uploaded a new version (http://permutations.com/drupal/phpfreechat.php).

I backed out setting the default timeout to 35000 in the module. It's not working because the "negative number" error is still happening after clearing the cache (/rehash). The timeout needs to be changed to avoid disconnects, and the easiest way to do this is to change it directly in pfcglobalconfig.class.php. phpFreeChat has an integer check in there, and Drupal's form API doesn't have an integer type. I tried to identify the integer strings and change them and it worked in a test file, but not in the module.

pfcglobalconfig.class.php is in the phpFreeChat src directory (it's not a module file).

  1. To change the default timeout, find this variable assignment and change the 20000 to 35000:

    var $timeout = 35000;
    
  2. To get rid of the negative number error, comment out this code in pfcglobalconfig.class.php:

    /*	
        $numerical_positive_params = $this->_params_type["positivenumeric"];
        foreach( $numerical_positive_params as $npp )
        {
          if (!is_int($this->$npp) || $this->$npp < 0)
            $this->errors[] = _pfc("'%s' parameter must be a positive number", $npp);
        }
    */	
    
permutations’s picture

I mentioned in an earlier message that this problem occurs when phpFreeChat is embedded inside a table and accessed with IE7. I created a theme that uses only CSS for positioning that works with phpFreeChat in IE7. For now it's available on my Web site here:

http://permutations.com/drupal/phpfreechat.php

I have applied for a CVS account on Drupal and if/when that is approved I'll move the project to Drupal.

permutations’s picture

Version: 5.x-1.0-rc4 » 5.x-1.2
Assigned: Unassigned » permutations

I have a CVS account now and uploaded a new version of of the module with many bug fixes (5.x-1.2). But this scrolling problem can only be fixed with a theme that doesn't use tables. You can still download the compatible theme from my own Web site:

http://permutations.com/drupal/phpfreechat.php

I'm planning to move this theme to drupal.org - just haven't had a chance yet.