attributes: string/array

Upgraded to priority normal.

There seems to be something wrong with drupals upload function now so I can't upload patch, so here is a manual fix
$attr = array('width' => $info['width'], 'height' => $info['height']) + $attributes;
should replace line 346 which was previously
$attr = 'width="'.$info['width'].'" height="'.$info['height'].'" ' . drupal_attributes($attributes);

Patch

theme_image has now changed back, so this patch should not be applied.

Should probably be applied against cvs but not 4.6

is this still an issue? doesn't look like it to me...

closing.

If I read the files correctly, the cvs version the function theme_image in file includes/theme.inc has changed and now wants an array instead of a string. For the 4.6.0 branch it wants a string and this patch should not be applied.

I am setting this to patch again for cvs, feel free to close it again if I have misunderstood anything.

I can confirm this is still an issue in CVS:

• clean install of drupal and image
• add an image
• the source says: <span class="image preview"><img src="http://localhost/~robrechtj/drupal-cvs/files/images/06_13_0.jpg" alt="a test image" title="a test image" /></span>
• notice that no width or height attribute is set!
• patching it (updated patch attached), gives: <span class="image preview"><img src="http://localhost/~robrechtj/drupal-cvs/files/images/06_13_0.jpg" alt="a test image" title="a test image"  width="640" height="480"/></span>
• note that the width and height are present

The reason is that in CVS "theme_image' now runs a 'drupal_attributes' on the 'attr' parameter. This parameter has changed from a string to an array in revision 1.235 of "theme.inc".

So, this patch NEEDS to be applied to CVS. And it SHOULD NOT be applied to 4-6.

Patch ready to be committed.

One more thing: drupal_attributes returns an empty string if $attr is not an array, that is why the width and height "disappear".

committed, thanks!