Drupal 6 port needs testing & feedback

+1 for porting this to D6.... Although having the maintainer not respond in nearly two weeks is a little unsettling.

Has anyone looked at the code and figured out what will be necessary to port it?

I'm also curious.

This is a very important module ... Someone has to update this please....

I'm also very interested about it.

Add me as well. Got a site running 6.2 and could really make use of this.

Hello, I also need this module. So I need to downgrade from Drupal 6.2 to a 5.x?
Thanks

+1 here, also a very useful module needed for Drupal 6.x !!!

Please some one update this module to drupal 6.. im prepared to donate some money to whoever port it first (must be working).. im sure most of are willing to donate too.. pleaseeee some one..

please put me on the waiting list as well. i need that module since i've upgraded to 6.2. thanks!

http://exodusdev.com/taxonomy/term/377

It looks like the developer *IS* planning on porting it...just low on their priority list.....

try to take a look at www.equnix.biz/~cmscomm/
point to iklan baris (classified ads). but the website is not finished yet, what do you guys say?

Thats too bad. :(

I am also interested in the 6.x version of this module.

add me to the list, I'm interested in the 6.x version

Hello,

I'm ok to help testing, just tell me what to do. ; )

+1 more - I am available to test as well. I can also contribute some code &/or some $$ to get the job done.

RE:

Why would anyone choose to use Drupal 6 for a production system if the modules they feel are critical are not ready yet?

My answer is: If not now when? if most of the modules I need are done and working, why not, it beats upgrading in 6 months or a year. I get to build in D6, get the exposure and bennies of D6 now.

Now a task.

hey. i'm available for testing :)

thanks for porting this to drupal 6 !

I'm still not using it, but plan to. I can test, and will check the donations page to drop some there as well :)

interested to help test.

Hi Inactivist,

I installed ed_classified and it appears just fine. All my pages worked fine until I turned on the proper flags so I can actually access and see the ads (duh!).

Cool, so then I clicked on the menu "Classified Ad" and got many pg_query() errors. This is because the QUERY needs a node identifier that does not exist for the 'latest'. Probably because there isn't a latest (or the query to determine the latest is broken, but I would need to know what that query is trying to do to make sure...)

So, anyway, I added a small fix to avoid the Postgres errors:

function ed_classified_page($type = NULL, $tid = 0) {
  // get a list of categories and counts
  $cats = taxonomy_get_tree(_ed_classified_get_vid(), $tid, -1, 1);
  for ($i=0; $i < count($cats); $i++) {
    $cats[$i]->count = taxonomy_term_count_nodes($cats[$i]->tid, EDI_CLASSIFIED_MODULE_NAME);
    $tree = taxonomy_get_tree(_ed_classified_get_vid(), $cats[$i]->tid, -1);
    $descendant_tids = array_merge(array($cats[$i]->tid), array_map('_taxonomy_get_tid_from_term', $tree))
    $last = db_fetch_object(db_query_range(db_rewrite_sql('SELECT n.nid FROM {node} n INNER JOIN {term_nod
    if(isset($last->nid)) { 
      $cats[$i]->latest = node_load(array('nid' => $last->nid));
    }
  }
  [snip]

(copy & paste from my console truncated on the right side.)

What I added is the if(isset($last->nid)) { ... } around the offending function call.

And btw, I seem to not receive the notifications either, what did you do to fix yours? I'll check my account closer to see whether I need to click on something there...

Thank you.
Alexis Wilke

Another thing, in regard to all the features you mentioned... We would need (post #17)

• Limit the # of files to download

I would think that requires a change in the core which, at this time, does not test any limit. I think that I would need a limit of 3. But if I need to change the core, then I'd need to deal with the person who handles the Upload module first... (then in your code, it would just be setting up one more variable in the form array.)

Let me know what you think.

Thank you.
Alexis Wilke

Hi Inactivist,

I guess you're right when you say that it won't work with Postgres... 8-)

Postgres requires that you use single quotes (') for all strings. You have a double quote in one place (so far):

ed_classified_utils.inc (line 181)

'... SELECT ... where type = \'ed_classified\' ...'

You may want to change the starting and ending ' for " and remove the \ character.

Either way, that fix works for me, and I would think it will work for MySQL.

Thank you.
Alexis Wilke

ok ... i will test this out later this week.

and provide whatever feedback i can

I will help

Hi guys,

Okay! I had to make this work for a customer, fully, under D6. So I made the fixes I deemed necessary to get the module to work for me.

I'm offering a patch and a tarball (because you cannot just get a tarball from the project, at least, not yet!)

As a side note: there are changes in this module that render it totally incompatible with D5. Also, there are fixes that could be back ported.

In D6, ed_classified_by_user() receives $account, not $uid.

The SELECT order to get the list of ads for a specific user was fixed so it also works under Postgresql. I'm not too sure why, but it looks like either PHP or Drupal cannot handle multiple columns with the same name. Maybe MySQL merges them and thus it works. Postgresql keeps them separate.

In that table, I changed the code handling the Total & Recent. Also unlikely, if these numbers are not available, it makes more sense (I think) to put 0 instead of nothing.

I do not add the empty edit column if $can_edit is not true because otherwise it appears as a very thin gray line on the edge.

For a few links, I added a title so people have more info about the link.

The patch also includes the fix I mentioned earlier.

The block is created using the description as a title attribute of the link to avoid having a huge block.

In two places, the $term was used directly, instead of $term->tid.

I changed the ed_classified_get_latest_ads_list() function to only show ads that have not expired. It does not seem sensical to show expired ad in that list. Plus, if these are the latest, why would an expired node be part of it?

Well... I think that was all for this module. 8-)

And by the way, I also fixed the lm_paypal module to work under D6 with your module here, see http://drupal.org/node/209287 for a tarball.

Thank you.
Alexis Wilke

Hi all. I just wanted to let you know that I've just set this up and am begining to work with it. At this point, I've set up only the dev version listed on the module page. I've just seen the patch and don't have the energy right now.

I'll try to play around with it in the next few days, but this is on a development server (so no live traffic). I'll let you know if I find any problems.

would anyone may be able to help me?

I've been waiting for this module for many months, and i am happy to see it come to light, however I don't know the steps to install it, I am a newbee (obviously).

Any kind soul out there, I'll be happy to send a donation towards your paypal, but i need it directly from the tit.

Please help

deejayrig (at] yahoo (dot] com

would anyone may be able to help me?

I've been waiting for this module for many months, and i am happy to see it come to light, however I don't know the steps to install it, I am a newbee (obviously).

Any kind soul out there, I'll be happy to send a donation towards your paypal, but i need it directly from the tit.

Please help

deejayrig (at] yahoo (dot] com

users with permissions to "edit own ads" are not able to edit or delete ads. Only users with permission "administer classified ads" can edit or delete ads. Using D6 dev release.

Happy to help in testing and development

@lpitman:I think there should be separate issue for each problem, Not getting the exact status of the issues and issue list.

subscribe

For two issues in D6, patches are ready.

All data in 'My Classified Ad list' link
http://drupal.org/node/332851

All revisions comes in the list
http://drupal.org/node/332828

Willing to help in testing the module.

I just thought of adding classifieds to my site today. Glad to see some recent activity here, at the bottom of the well.

Willing to help in testing the module too, or provide resources. I think we may have a spare server somewhere I can put online.

Hi Alexis,

Nice patch fixed a fair few major bugs.

I have a few questions if you have the time

what purpose is the classified_auth field as I can't see it actually used anywhere other then select queries ( I have taken it out of my select queries)

The only user that sems to be able to edit classified ads is admin All others get a Access denied error (even with all the possible ads settings enabled i.e. administer ads, edit own ad etc) How have you got this working..?

I'm using the image.module to allow multiple images to be attached to each ad, however only admin seems to have this ability no other user seems able to see the image field.. any clues ...?

regards

Surj

Hi everyone,
I tested the D6 version of this module and it appears that some fixes need to be made on :
- Expiration notification email : actually no email is sent to the ad owner
- Purge expired ad : The ads are not deleted nor unpublished
Did someone got these problems ? If not I'm willing to fix these problems.
Thanks for help,

Hi Heilong,

I installed the patch posted in #34 above and it did remove/unpublish expired ads after cron was run.

However, the email notification code does not work -- it doesn't seem to be finding the "send to" (recipient) emails properly and the from email formatting also causes errors (easily rectified by simplifying & removing "Reply to:" etc. stuff in quotes) @line 92 in ed_classified_notifications.inc . I'd love it if someone could correct this bit, I can't figure it out!

Also, the installed blocks (e.g. Classified Ad - lastest & popular) don't seem to be working properly, although this is easily worked around by creating a custom view/block.

After running cron, the expired ad has been deleted, but no notification sent.
I'll get inside the code to try to figure it out...

I am plannimg to use the classifieds module for D6, but am unsure what patches/fixes need to be installed with the module for it to work? Can you please help me identify all the patches for D6 required for a production site?

Thank you.

I've been testing this module on a site about to go live, and it seems to be okay, but when cron rolls around, I think the module's doing some heavy maintenance tasks, which result in cron timing out...

After running cron, ads that already expired can be deleted depending on the settings, but the email notification is not sent when an ad expires soon. Trying to figure it out, if any patches about that I'd like to know...
Thanks,

After a couple weeks of testing, it seems like my biggest two issues with this release are:

1. Cron keeps timing out, and no emails are sent when an ad is about to expire (part of the cron run).

2. Every user on the system has all the ads under his/her "my classified ads" profile page tab.

geelingguy,

For second issue, attached patch.

Sorry...guys,
how the patch must be applayed?

I mean... what I have to do? copy that file? and if yes where in the module folder?

Cheers

@ bagherozzo21 - See "Applying Patches" - http://drupal.org/node/60108

thanks!!

;-)

To all - please see AlexisWilke's patch in #27 above - for some reason, that post got stuck far up the page, so many people probably won't notice that it is one of the more recent posts on this topic. Please test it; maybe we can get the release version on the project page up to speed if the patch is reviewed and tested by the community.

I hate having patched and hackneyed modules running on my live sites ;-)

I'm getting cron timeout with the the latest patch . For a temporary fix, since I don't need to mail notifications, I commented out line 197 in ed_classified_utils.inc.

I'll look into this more. It looks like _ed_classified_notify_user_of_ad_expiration(); is missing.

RE: the tarball in #34 works, but the notification of ad expiration still doesn't work (not an essential feature for me, so I just commented it out in the utils.inc file).

Is there going to be any more work on this module? I would offer to help, but all I can do is test, as I'm not very good with PHP and would probably just mess things up.

Hi geerlingguy,

If it works for you, why do you need more now? 8-)

I do not need it anymore since my customers went out of business. But if you have some cash on hands... I can always help. I already have many other modules I'm working on so I cannot really do more for free.

Thank you.
Alexis Wilke

For me #34 works fine

Ummm... what is going on with this thread?? 9 status updates in a couple hours?

Looks like grateful_drupal_user removed all his posts... weird.

I have an interest in seeing this module completed and possibly enhanced. Rather that do it alone, I'd prefer to give something back. How would this work and who could do it? What extra features would everyone like to see? And of course, how much?

[Whoops! Posted in wrong thread.]

I'm interested in doing more with this module, I have a live site with exactly this requirement. Initially, I'm happy to start doing some bug fixes and feature enhancements on the drupal 6 branch see where that leads. I've done all my coding and module development on my own servers, not via drupal.org so I'll need to work out what I have to do first [aha, silly me, it's via patch submission - I'll give it a try].

Patches are always welcome... and if you want to have a multitude of sins erased, becoming the module maintainer would be even more welcome ;-)

I would be more than happy to become the maintainer - particularly if through cosmic dispensation of karma I come out in the positive.

Cheers,

Miles

milesgillham,

There isn't a maintainer at this time, so it can be all yours!

Enjoy...

Fair enough. I've created a support request for the project requesting endorsement from the existing maintainer.

Cheers,

Miles

Hooray! This is pretty awesome. If I knew PHP better than I did, I would've liked to do it, but I would probably end up ruining a good module. Since you're able to do it, it will help countless others :-)

Since I'm using the module on a live site www.stlouisreview.com, I take great interest in any of your development. I'll definitely be able to do some testing.

Hmmmm #34 seems to work for me as well except for the fact that a normal user that has the option to edit his own classified cannot... users get an access denied error... any fixes out there?

Found the place where it is setting the permissions... in the ed_classified.module file on line 329

$can_edit = user_access('administer classified ads') || ($uid == $user->uid && user_access('edit own classified ads'));

will try and figure out a fix for this and post it up here if i do...

Yep, see http://drupal.org/node/355119

I'm just waiting to get CVS access and I'll apply the critical bug fixes. Will take a look at what Alexis has provided in #34 also. Then I'll get an official 6.x alpha release out. Probably by next week.

Cheers,

Miles

sweetness... thanks for the link with the fix... works now... (saves me the headache of trying to figure it out) :D

Fixes from #29 and #31 applied to 6.x development branch

#34 requires more work to review the patch

#38 fixed by http://drupal.org/node/355119

#41 being handled separately in the links that phdhiren refers to

#47, #48 subject to testing in the dev branch right now

#49 happy to hear more about this, but lodge as separate request

#60 - there are a few general comments about cron timeouts, if still happening lodge a new request with more detail such as how many ads you have active

#66 - just start lodging feature requests, this module is actively maintained once more

In general, please do not submit any further bug fixes, support requests, or feature requests against this particular issue (becoming too long and too mixed) - lodge them as separate issues from here forward please to ensure nothing is missed.

Once #34 is sorted out I will close this issue and release an alpha2 release by next week (as #34 already tacitly provides an alpha1).

Cheers,

Miles

YAY!!! (as webchick would say).

Thank you for taking this on; it is greatly appreciated.

Is the -dev release ready for testing? If so, it's going up on my live site a.s.a.p. (next week sometime). I'll give as much feedback as I can.

No worries, happy to help. :-)

I've been busy developing / applying patches. Alexis Wilke has done a great job with that (large) patch in #34 and I'm spending a fair amout of time right now processing it. I really don't recommend going near the -dev for at least a couple of days as I still need to do some basic sanity checking to ensure that all of these modifications are consistent, tested, and the documentation current.

The moment it is remotely stable I'll go straight to issuing an alpha2 release so you'll know when it's worth grabbing. Still looking good for next week at this stage.

Cheers,

Miles

Alexis, I've completed applying the impressive quantity of elements in your patch in comment #34. It's pretty much mostly in the bug fix camp, with improvements such as link titles. I have enough to go ahead to an alpha release that won't regress from your alpha1 submission. However, I haven't applied the classified_auth column as I'm not entirely certain what the purpose of it is. I see that it is referenced and updated, but I'm unclear (or have missed) as to how it is used.

I'll park those pieces for the moment until I can understand what you were doing with that. Otherwise, a very big thank for the work!

Cheers,

Miles

milesgillham,

If I recall, the problem I ran into (and there may be a better way to fix it) was that the users could publish anything they wanted. You could later check and make sure the ads were "clean" but you could not verify before it got published. I added the flag so users could publish their ad that would remain hidden until an admin or moderator marked the ad as acceptable.

Thank you.
Alexis Wilke

Ah, I see. On first glance, the modr8 module (http://drupal.org/project/modr8) might do that in a generic Drupal way. I'll add "ad moderation" to the roadmap to remind me to test ed_classified with modr8, and possibly put hooks into modr8 API if detected and needed.

Other than that, the only part of your patch bundle that I haven't applied is:

The SELECT order to get the list of ads for a specific user was fixed so it also works under Postgresql. I'm not too sure why, but it looks like either PHP or Drupal cannot handle multiple columns with the same name. Maybe MySQL merges them and thus it works. Postgresql keeps them separate.

The code in ed_classified.module looks like:

// outer join allows us to see nodes that have no entries in the node_counter table
    $sql = "SELECT n.*, ec.classified_auth, ec.expires_on, ec.expiration_notify_last_sent, nc.totalcount, nc.daycount FROM {node} n, {edi_classified_nodes} ec LEFT OUTER JOIN {node_counter} AS nc ON nc.nid = ec.nid WHERE n.vid = ec.vid $unpublished $user_select "  . tablesort_sql($header);

Previously:

// outer join allws us to see nodes that have no entries in the node_counter table
$sql = "SELECT * FROM {node} n, {edi_classified_nodes} ec LEFT OUTER JOIN {node_counter} ON node_counter.nid = ec.nid WHERE n.vid = ec.vid $unpublished $user_select "  . tablesort_sql($header);

Not being a postgres user I just didn't understand how it worked. I'm going to move forward without the classified_auth column just for now (in prep for a more generic moderation solution), so I think that line should now look like:

    // outer join allows us to see nodes that have no entries in the node_counter table
    // The select columns have been modified to work for postgres
    $sql = "SELECT n.*, ec.expires_on, ec.expiration_notify_last_sent, nc.totalcount, nc.daycount FROM {node} n, {edi_classified_nodes} ec LEFT OUTER JOIN {node_counter} AS nc ON nc.nid = ec.nid WHERE n.vid = ec.vid $unpublished $user_select "  . tablesort_sql($header);

I'll load that into the dev branch and look for feedback on how it works for postgres users.

I will now flag this issue thread as "fixed", moving forward as I've proposed in #77 and #79.

Cheers,

Miles

That should work find.

When done this way:

SELECT * FROM {node} n, {edi_classified_nodes} ec

you were getting two columns (one from node and one from edi_classified_nodes) that were in conflict (i.e. had the same name). By selecting just what we need from ec, we eliminate the Postgresql problem.

Thank you.
Alexis

P.S. look at both tables, I suppose nid is one of the common columns

I've released 6.x-2--0-alpha2 early (but hopefully not prematurely). It is not recommended for production sites but does give a point of reference for ongoing bug fixes and planning of feature enhancements. The bug fixes applied appear fine except I'm not certain that the e-mail notifications are actually working as intended. Feedback on those would be helpful. Again, don't post any new bug fixes or requests to this issue, start new ones so that they can be tracked against alpha2.

Cheers,

Miles

All known critical bugs for 6.x branch fixed, now reflected in -dev branch and the alpha3 branch is now released. It appears stable enough to let rest for a while and take feedback and bug reports.

Cheers,

Miles

Sweet - will download either today or Thursday and apply to my live site (always backed up, of course).

Please let me know how it goes. I've also updated the project page with thoughts on the future vision along with intended features to go into the first beta release (based upon comments I've seen in support requests and forums across Drupal.org). Would love feedback on that.

Cheers,

Miles