Porting hovertips to 6.x

NancyDru - February 22, 2008 - 22:49
Project:Hovertips and Clicktips
Version:5.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

Will there be any?

#1

Dave Cohen - February 24, 2008 - 00:37

Yes, eventually. Patches are welcome, if anyone wants to help. It's a small module and may not need much to upgrade.

#2

NancyDru - February 24, 2008 - 01:18

Actually, here's a patch. I've done the Drupal part, but the jQuery needs attention and I don't know that part.

AttachmentSize
hovertip_6.patch 3.86 KB

#3

NancyDru - February 25, 2008 - 23:06
Assigned to:Anonymous» NancyDru
Status:active» needs review

Scratch that one, I missed two small things. Now this completely works on 6.x.

AttachmentSize
hovertip_6.patch 3.94 KB

#4

deselaers - March 29, 2008 - 18:12

Hi,

I have applied this patch, and now hovertip seems to be working fine in my Drupal 6.1 installation.

Cheers,
thomas

#5

wayland76 - April 26, 2008 - 02:54
Title:6.x support?» Porting hovertips to 6.x

Dave, is there any chance you could commit this patch?

#6

wayland76 - April 26, 2008 - 03:00

(After branching CVS appropriately, of course)

#7

NancyDru - April 26, 2008 - 03:10

And doing more testing? Someone else testing and marking RTBC would be nice.

#8

wayland76 - April 28, 2008 - 04:49

Hmm. Doesn't seem to work quite right.

http://www.housingaffordabilityaustralia.com/content/hovertips-test

I'm using the chameleon theme that comes with D6. In firefox, the hovertip comes up any time I'm over that window, rather than just when I hover over the appropriate text. Maybe I'm doing something wrong too, which is why I'm posting the link here.

#9

wayland76 - April 28, 2008 - 04:57

Ok, maybe it does, and I'm wrong. I finally got the Glossary and Hovertips working together here, and they seem to work properly :).

#10

wayland76 - April 28, 2008 - 05:22
Status:needs review» reviewed & tested by the community

...so I guess what I'm saying is, the patch is fine, but the documentation could probably use some work :).

#11

wayland76 - April 28, 2008 - 07:18
Status:reviewed & tested by the community» needs work

Ok, I've found a problem -- hovertips are only working if I'm logged in as Administrator, not anonymous. That's no reason not to create a 6.x dev branch, though :).

#12

NancyDru - April 28, 2008 - 12:47

6.x has a new version of jQuery, and I suspect there is some tweaking required, but I don't know how to do that part.

#14

NancyDru - May 2, 2008 - 00:54

I know about the docs, but I am not a jQuery or js person.

#15

wayland76 - May 2, 2008 - 01:36

@NancyDru: Sorry, that wasn't directed at you, but more at someone who wants to get in and give this problem a shot.

#16

Dave Cohen - May 2, 2008 - 17:58

I think the new version of jquery could make hovertip.js shorter (because I think jquery provides some of the coordinate nastiness in there now) although I'm not certain about that.

I've been sluggish to check in an Drupal 6 changes because personally I have not yet upgraded any of my sites. I will get to this, though! I appreciate the help.

#17

NancyDru - May 3, 2008 - 00:38

I've only got my one test site so far, and it is not a really good test bed yet. I have most of my modules converted, but the jQuery is beyond me at the moment. Sorry I couldn't do that part too.

#18

jhedstrom - May 9, 2008 - 17:56

I resolved the issue with non-admin users being able to see the tips. The problem was in hovertip_menu, in that apparently access arguments can't simply be array(TRUE). I set it to array('access content').

I also reviewed the js, and it didn't look like it needed any updating.

AttachmentSize
hovertip_6.patch 3.92 KB

#19

NancyDru - May 9, 2008 - 18:04

They can be, but I may not have done it properly. AFAIC, that's a good solution - if they can't see content, then why are they even on the site.

#20

jhedstrom - May 9, 2008 - 18:21

They can be, but I may not have done it properly.

I assume it can be done, I just couldn't figure out how to do it via the Drupal API.

I suppose one could simple change the "access callback" to "is_array" and pass in "array(1)", but this seems hacky at best.

#21

NancyDru - May 9, 2008 - 18:26

I remember running across it somewhere in the upgrade docs, but don't remember where right now.

#22

wayland76 - May 11, 2008 - 23:09

@Dave: Can we at least have a dev branch for this? If you need help with the release system (including CVS), I can help with that (I assume you don't need this, but since there's been no 1.x version, I thought I'd offer).

#23

wayland76 - May 11, 2008 - 23:14

@jhedstrom: what is this patch against?

#24

NancyDru - May 11, 2008 - 23:35

My base was: $Id: hovertip.module,v 1.3 2007/12/12 19:23:34 yogadex Exp $

#25

wayland76 - May 14, 2008 - 01:35

Ok, here's mine against current HEAD, which Dave is updating for the first time since last year. Hopefully he'll be willing to branch for 6.x :).

AttachmentSize
hovertip-6.x-port.patch 3.65 KB

#26

wayland76 - May 15, 2008 - 09:03
Assigned to:NancyDru» Anonymous
Status:needs work» needs review

Forgot to change status; sorry. Nancy implied that she'd done as much as she could on it, so I'm reassigning it to no-one.

#27

Dave Cohen - May 15, 2008 - 22:28
Status:needs review» fixed

Thanks everyone for your work on this. And also for your patience.

Sadly, I'm stuck in the Drupal 5.x world for every site I'm working on. So setting up my environment for 6.x has been something of a hurdle. I don't want to delay you any further so I've checked in the patch - without testing it. Something I'm loathe to do, but just resurrect this issue if I've blundered.

http://drupal.org/node/259042

#28

Anonymous (not verified) - May 29, 2008 - 22:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.