the settings menu for the provision module is badly broken. here, it crashes apache with what looks like an infinite loop.
The attached patch restores proper behaviour and also adds a submit hook, which seemed to be missing. I made it so the submit hook calls all provision modules.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | mysql_submit.patch | 2.46 KB | anarcat |
| mysql_submit.patch | 3.03 KB | anarcat |
Comments
Comment #1
anarcat commentedThe first patch had some whitespace changes in it, this one is cleaner.
Comment #2
adrian commentedThanks for the patch.
I'm currently busy refactoring this code, to keep pace with the move away from cck.
Due to the fact that I am doing all the forms for the types myself, I am moving the settings forms into provision, and merging them into
the node forms on the front end as necessary.
With some custom handling of the submit hooks, I will be able to provide a much simpler mechanism for maintaining the provision settings.
(the provision settings are tied directly into the platform that hostmaster is currently running as, so centralizing the codebase cleans up a lot of places where errors could creep in)
Comment #3
adrian commentedComment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.