USABILITY BUG: Default search form cannot be removed via Themes global configuration if Search module deselected
shiva7663 - February 23, 2008 - 15:54
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | search.module |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active (needs more info) |
Jump to:
Description
When the Search module is activated, it enables a default search form which cannot be moved or removed via the Blocks configuration page.
#1
That's because it's a theme setting, and can be configured at admin/build/themes/settings.
#2
Interesting. My first attempt to resolve the issue by turning off the Search module failed because the option to turn off Search in the Themes global configuration page was grayed out: I had to re-enable the Search optional module, then return to the Themes global configuration page to deselect the default Search feature, then return to Modules list to deselect the Search module.
I think turning off the whole Search module should have automatically deselected the default Search feature in Themes global configuration instead of just graying out the checkbox while leaving it selected. I've changed the title of the issue to better reflect what happened.
#3
I agree with shiva7663. This is a usability bug.
#4
This seems to work fine in D7.
Here is what I did:
I checked the code (includes/themes.inc) and I see that there is code to disable the theme setting for search box when the search module is disabled:
INSIDE function theme_get_settings($key = NULL) lines 889 to 894:
1.209 (dries 20-Aug-04):
1.217 (unconed 14-Oct-04): // Only offer search box if search.module is enabled.
1.309 (unconed 20-Aug-06): if (!module_exists('search') || !user_access('search content')) {
1.217 (unconed 14-Oct-04): $settings['toggle_search'] = 0;
1.217 (unconed 14-Oct-04): }
1.217 (unconed 14-Oct-04):
RCS file: /cvs/drupal/drupal/includes/theme.inc,v
Working file: includes/theme.inc
head: 1.430
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 465; selected revisions: 1
description:
----------------------------
revision 1.217
date: 2004-10-13 22:38:32 -0400; author: unconed; state: Exp; lines: +6 -1;
Theme system bug: only show search box if search.module is enabled.
=============================================================================
RCS file: /cvs/drupal/drupal/includes/theme.inc,v
Working file: includes/theme.inc
head: 1.430
branch:
locks: strict
access list:
keyword substitution: kv
total revisions: 465; selected revisions: 1
description:
----------------------------
revision 1.309
date: 2006-08-20 01:57:40 -0400; author: unconed; state: Exp; lines: +4 -4; commitid: ff844e7f9c84567;
#79601: module_exist() -> module_exists()
=============================================================================
I tried it with D6 and D5 and they all behave the same way. Disabling the search module makes the search box unselected in the theme global settings.
What am I missing?