Closed (won't fix)
Project:
Views (for Drupal 7)
Version:
5.x-1.6
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Feb 2008 at 19:32 UTC
Updated:
4 Aug 2010 at 18:27 UTC
PHP 4.4.10
Drupal 5.5
In Views module: views_node.inc: function views_handler_field_body() line 456:
node_invoke($node, 'view', $teaser, TRUE);
contains a bug, because hook_view (as explained in http://api.drupal.org/api/function/hook_view/5) function call RETURNS the $node object.
Your code works only if $node passed by reference, but API docs does not mention this.
It will be better to write this code:
$node = node_invoke($node, 'view', $teaser, TRUE);
Comments
Comment #1
gotheric commentedI agree with this patch.
Comment #2
bago commentedI agree, too.
This issue affect the same code line as http://drupal.org/node/176360
Comment #3
esmerel commentedI'm going to go ahead and mark this 'needs review' in case one f the maintainers has a chance to look at this before the 1.x line is deprecated.
Comment #4
esmerel commentedAt this time, only security fixes will be made to the 5.x version of Views.