I'd like to mark and already translated and approved translation as fuzzy. From time to time you approve something wrong and like to roll back this or you missed to check the mark as suggestion checkbox on a file import and we need to unapprove a string.

Comments

hass’s picture

hass commented
Version: 5.x-1.x-dev » 6.x-1.x-dev
Priority: Normal » Critical

Marking as critical feature for live deployment of http://localize.drupal.org/

hass’s picture

hass commented
Title: Allow marking approved translation as fuzzy » Allow marking translation as fuzzy
hass’s picture

hass commented

If fuzzy does not mean "needs work" or "could be better" or "need to be re-written" this is a duplicate of #251327: Flag translation as 'golden' vs 'need work'

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Hum, you mean you should be able to unapprove a string / demote from translation to suggestion?

hass’s picture

hass commented

Yes. We have had many situations where the reviewers made mistakes... I remember one guy with ~280 self approved strings and/or buggy approved strings from others... the "approve others suggestions only" may not help us here much and it's important to have the ability for admins to turn this approved string back. It need to work like a CVS roll back...

I believe you do not like to change every second day something on DB level if the server is in production :-).

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented

subscribe
I think this is duplicate for second part of #605748: Approve Selected + Decline unselected at once in moderation

zirvap’s picture

zirvap commented
Title: Allow marking translation as fuzzy » Allow marking translation as suggestion
Priority: Critical » Normal

Changing the title, as "fuzzy" and "suggestion" isn't the same thing (or at least doesn't need to be, ref. #204150: Differentiate fuzzy and suggestions). I'm also changing it from critical to normal. I agree that the feature would be nice to have, but it's not absolutely vital to the translation work.

Re #6: This issue is not a duplicate of #605748: Approve Selected + Decline unselected at once in moderation, as far as I can tell.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, when you submit some text, you can always decide whether it is a suggestion or a translation (if you are privileged enough), or you always submit suggestions if you are not. If this is all this issue is about, then we can consider it closed, since this is how it works for the past years :)

zirvap’s picture

zirvap commented

As far as I can tell, this issue is about demoting an accepted translation back to suggestion again. I can see the following use cases:

- Just after approving a suggestion, I notice some problem with the string, and want to set it back to suggestion again (of course, I might just as well fix the problem instead)

- Some approved strings have problems, I want to bounce them back to suggestions and then take the time to work on them later (or maybe notify whoever's translated them that they should work on them)

(Personally I'd set the priority here to "minor", but as it started as "critical", that feels like a too big jump. I noticed this issue only because I was searching for "fuzzy", and saw that this one was mis-labeled.)

hass’s picture

hass commented

It's definitely to roll back an already approved string and role it back to the previous one that may have been much better.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

Well, Konstantin's UI patch has this feature to jump strings back and forth between being suggestions and translations, where declining a string is a different action to marking stuff as suggestion or translation (ie. you can pick a translation while you can still keep existing suggestions === you can pick which string is the active translation without ever declining a suggestion if you want to). Since that includes this feature, I'm not sure we should have a separate effort to implement this. See #563128: Rework the translation UI.

Actually, it might not allow you to get back to the "no translation" state when a translation was already picked, so it might not be feature complete in this regard as far as I remember.

hass’s picture

hass commented

I wasn't aware about this... really bad that #563128: Rework the translation UI hasn't been "finalized" yet... I know we are all busy, but are you not able to pick this one up as highest priority patch and get this one finally in? :-)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@hass: I'm working on pre-requsities (break-out patches to make the UI patch smaller) as much as I could in the past weeks/months. More contributions would obviously be welcome on that issue as well.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Active » Closed (duplicate)

So as said, #563128: Rework the translation UI already includes this.