PHP Error on subscriptions.module line 456

Thanks for pursuing this. Apparently, the FeedAPI nodes aren't quite standard, if it works with manually created page nodes, but I fail to see the connection between odd nodes and the error you describe. Or the FeedAPI nodes trigger different subscriptions than your manually created ones.

What you describe looks more like having recipient_uid's in the {subscriptions} table that aren't in the {subscriptions_user} table.

Could it be that you have left-over recipient_uid's from 1.x that don't correspond to currently existing users in the {users} table (from which the {subscriptions_user} table was built)?

Yes, UID -2 in {subscriptions_user} is the global default record — sorry, I should have told you.

-1 in {subscriptions}.author_uid means no specific author, i.e. subscriptions for all authors. That looks fine, but what is type "link"? I've never seen that. Is that what's created by FeedAPI? Can you edit these, too, to try resending?

I'm totally in the dark here.

Try comparing a page node from FeedAPI and one that you created manually, or maybe before and after you edit it (you wrote that after editing there were no complaints).

There must not be a uid=0 row in subscriptions_user. Please remove that row.

subscriptions_mail_cron() has no problem running under the anonymous user; we are way beyond this type of error. This is an issue that is unique to your system, which doesn't mean we don't need to fix it, but unfortunately I can provide very little help.

Please try to find out where that 0 comes from. Start by checking what $account parameter you get in _subscriptions_get_setting(). It can be a user object, a uid (if > 0) or a rid (if < 0).

Ah, now I'm beginning to understand. We're in cron.php, but not in subscriptions_cron(). We're in FeedAPI_cron() (whatever it's called)! And we're trying to check whether the cron user wants to autosubscribe to the node that FeedAPI is creating.

Have you tested subscriptions with nodes created by modules during cron execution before?

That's exactly the point: no. Now we know where to look.

You're right, subscriptions_notify not being set is the problem.

Please check whether FeedAPI calls hook_nodapi($node, 'prepare') and try to set $node->subscriptions_notify=TRUE at that time. I think that would be the proper place. Defaulting to TRUE would also be an option, but a less delicate one.

I need to look more closely into _subscriptions_get_setting(), but creating that uid=0 row actually might be the solution.

Thank you for digging into this!

Please try the attached patch — it should fix both issues.

I observed this error in watchdog but it disappeared before I was able to review this patch. I tried adding per-content type subscriptions for uid 1 and an authenticated user and ran cron but still can't recreate the error.

Are there any specific steps I could take to create the error and help test this patch?

The error is likely to occur if "something" creates nodes on your site without going through the regular Create-content-and-[Submit]-the-form cycle.

Yes, I'd be very interested to hear whether it works for you! Creating nodes in odd ways is a challenge for modules like Subscriptions.

I'll try programatically creating a node and seeing what happens.

Without applying the patch, I still don't get this error programatically creating a node and running cron.php. I've tried this with subscriptions disabled and enabled as well as with $node->uid 0 and also with 1. I create the node by executing the following code in the devel excecute php block:

<?php
$node = new stdClass();
$node->type = 'page';
$node->title = 'This is a test';
$node->body = 'this is the body';
$node->name = 'ezra';
$node->uid = 1;
$node->status = 1;
$node = node_prepare($node);
$node = node_submit($node);
$node = node_save($node);
?>

I also don't get the errors when I simultaneously have multiple programatically-created nodes of both uid 0 and uid 1.

I suspect you'll get the error when you don't call node_prepare(). Maybe you even have to drop node_submit()...

I don't know what exactly FeedAPI was doing, but somehow it didn't call the required hooks, probably as uid 0.

I still can't get the errors to come back. I've tried to recreate the errors by creating nodes without node_prepare() and without node_submit(). It's worth noting that I never had FeedAPI enabled on this installation. I also tried creating a node by simply performing, similar to the code in feedapi.module feedapi_create_node() :

<?php
 $node->type = 'page';
  $node->title = 'test node';
  $node->body = 'test body';
  node_object_prepare($node);
  node_save($node);
  return $node;
?>

Well, thanks for trying. The posted fix will be in BETA12 (and I'll set the status to fixed when it's out).