Any plans to port this in the near future?

CommentFileSizeAuthor
#1 quote-6.x.patch5.74 KBheirecka

Comments

heirecka’s picture

heirecka commented
Status: Active » Needs review
StatusFileSize
new quote-6.x.patch5.74 KB

I tried to port this, but it's my first attempt at module development. It seems to work without errors, but coder module complains about one line:

Line 208: form_set_value() parameters have changed (Drupal Docs)
form_set_value($form['quote']['node_types'], array_filter($form_state['values']['quote']['node_types']), $form_state);

Can someone please resolve this (and other mistakes I made)?

The path is against quote-5.x-1.x-dev (last updated 14 Decemeber)

naheemsays’s picture

naheemsays commented

Can you attach your patch again please?

(in my attempt I got stuck on that same line - but none of it worked.)

naheemsays’s picture

naheemsays commented
Status: Needs review » Reviewed & tested by the community

The patch works.

I say ignore coder module (or file a bug against it) unless someone can actually find something wrong with the patch. (I attempted very similar stuff, but it threw up a lot of errors.)

Zen’s picture

Zen commented
Assigned: Unassigned » Zen
Status: Reviewed & tested by the community » Fixed

Thanks heirecka and nbz. The patch has been committed with some modifications.

@heirecka: The coder module warning that you refer to appears to be a false positive.

If somebody can test the DRUPAL-6--1 branch and confirm that everything works, I'll release DRUPAL-6--1-1.

naheemsays’s picture

naheemsays commented

Just tested it and I can confirm that the module works.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.