Posted by nbz on February 25, 2008 at 4:00pm
3 followers
| Project: | Quote |
| Version: | master |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Zen |
| Status: | closed (fixed) |
Issue Summary
Any plans to port this in the near future?
| Project: | Quote |
| Version: | master |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Zen |
| Status: | closed (fixed) |
Any plans to port this in the near future?
Comments
#1
I tried to port this, but it's my first attempt at module development. It seems to work without errors, but coder module complains about one line:
Can someone please resolve this (and other mistakes I made)?
The path is against quote-5.x-1.x-dev (last updated 14 Decemeber)
#2
Can you attach your patch again please?
(in my attempt I got stuck on that same line - but none of it worked.)
#3
The patch works.
I say ignore coder module (or file a bug against it) unless someone can actually find something wrong with the patch. (I attempted very similar stuff, but it threw up a lot of errors.)
#4
Thanks heirecka and nbz. The patch has been committed with some modifications.
@heirecka: The coder module warning that you refer to appears to be a false positive.
If somebody can test the DRUPAL-6--1 branch and confirm that everything works, I'll release DRUPAL-6--1-1.
#5
Just tested it and I can confirm that the module works.
#6
Automatically closed -- issue fixed for two weeks with no activity.