This patch removes this notice:

Undefined property: stdClass::$last_open in includes/xmlrpc.inc on line 259.

Reported by Zlender in irc. To test, run something like the following after bootstrap:

xmlrpc('http://path/to/xmlrpc.php', 'blogger.getUsersBlogs', 'foo', $username, $password);

CommentFileSizeAuthor
#7 226555jv.patch845 bytesjvandyk
#5 226555.test_.txt496 bytesvladimir.dolgopolov
#3 xmlrpcnoticefix.patch838 bytesRok Žlender
#2 xmlrpcnoticefix.patch1.22 KBRok Žlender
noxmlrpcnoticejv.patch842 bytesjvandyk

Comments

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Subscribe. I saw this with a module I was trying to port recently.

Rok Žlender’s picture

Rok Žlender commented
StatusFileSize
new xmlrpcnoticefix.patch1.22 KB

I changed your patch a bit and it now removes all notices. Please check first change in my patch if it is ok not sure if we are checking if is_date is set or if its true.

Rok Žlender’s picture

Rok Žlender commented
StatusFileSize
new xmlrpcnoticefix.patch838 bytes

Removed is_date problem. So now this patch only tackles what is described in description. It works well for me and it removes silly exceptions in simpletest.

jvandyk’s picture

jvandyk commented
Status: Needs review » Reviewed & tested by the community

Patch in #3 removes the notice.

vladimir.dolgopolov’s picture

vladimir.dolgopolov commented
StatusFileSize
new 226555.test_.txt496 bytes

I have written the test for it for Simpletest module.
Unfortunately, one hasn't assertError() method, so there will be:
Before patch: 0 passes, 0 fails and 1 exceptions.
After patch: 0 passes, 0 fails and 0 exceptions.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Needs work

I'd add parenthesis to make sure what is the priorities. Otherwise looks good. Thanks Vladimir for the tests!

jvandyk’s picture

jvandyk commented
Status: Needs work » Needs review
StatusFileSize
new 226555jv.patch845 bytes

I think this is what you meant by adding parentheses.

dries’s picture

dries commented
Version: 7.x-dev » 6.x-dev
Status: Needs review » Reviewed & tested by the community

I've committed this to CVS HEAD. Thanks all. I'm moving this down to Drupal 6 for Gabor to review.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed to Drupal 6 as well.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.