Patch to block.module to comply with ANSI standards.

CommentFileSizeAuthor
#4 ansi-block-0.3.patch2.35 KBhswong3i
#3 ansi-block-0.3.patch2.17 KBobsidiandesign
#2 ansi-block-0.2.patch2.3 KBhswong3i
block-ansi-standards.patch1.32 KBAnonymous (not verified)

Comments

hswong3i’s picture

hswong3i commented

This issue is strict forward and simple, +1. BTW, it is duplicated with http://drupal.org/node/199101.
Tested with MySQL and PostgreSQL, pass.

hswong3i’s picture

hswong3i commented
StatusFileSize
new ansi-block-0.2.patch2.3 KB

one more catch.

obsidiandesign’s picture

obsidiandesign commented
StatusFileSize
new ansi-block-0.3.patch2.17 KB

Rerolled against latest head. Applies & works correctly with both MySQL and PostgreSQL. Simpletests run successfully for block module. +1

hswong3i’s picture

hswong3i commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new ansi-block-0.3.patch2.35 KB

Patch reroll via CVS HEAD, create with correct path and location. Clean and function for both MySQL and PostgreSQL.

damien tournoud’s picture

damien tournoud commented

Please convert the first query to use the new placeholders (:var-name) and the second one to use the query builder.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Needs work
casey’s picture

casey commented
Status: Needs work » Fixed

http://api.drupal.org/api/function/block_form_user_profile_form_alter/7

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.