Translation directory change

Good idea, please test the attached patch. It looks for the presence of ./po without ./translations. If you run this on many modules with several directories that need to be moved, it will give you the error only once, and only mention that one directory. It would be better to show it foreach directory that needs to be moved, but I think that this is an edge case that probably doesn't deserve the extra half-dozen lines of code we'd need to do that.

I get the error:

Parse error: syntax error, unexpected ')' in /var/www/drupal_6.1_20080212/html/sites/all/modules/coder/includes/coder_6x.inc on line 509

Removing the extra ')' fixes it. I've re-attached a fixed version of the patch.

The patch does correctly identify that I have a 'po' directory instead of 'translations'. However, the warning is printed once for each file in the module directory, so it's printed for e.g. faq.install, faq.module and for each of my 8 theme tpl.php files. Maybe it should just alarm on the first one?

Cheers,
Stella

The same is not true for me. Once I fixed the directory name, no more warnings appeared.

I don't see how it could be, but I guess there's no harm trying. It's not there as a hidden directory, no?

freso@nayru /s/h/l/h/d/s/a/m/c/includes> patch -p0 < ../226965_0.patch
patching file coder_6x.inc
Hunk #1 FAILED at 498.
1 out of 1 hunk FAILED -- saving rejects to file coder_6x.inc.rej

(Why was it set to "active" instead of "patch (foo)"?)

Here's a re-roll. I think, though, that it should probably only appear for either .module or .info. The current one makes it way cluttered, and it's not that critical an issue.

@nancyw: I had the same problem (created a 'po' dir to trigger the warning, then made a 'translations' dir to remove it again... only it didn't), but clearing the cache solved the problem. So it looks like a cache issue.

@Freso, You should only get this error once per module. What project did you use that displays the error for each .module and .install?

@douggreen: snpower wrote However, the warning is printed once for each file in the module directory, so it's printed for e.g. faq.install, faq.module and for each of my 8 theme tpl.php files. – and I see the same behaviour. But if you really must know, I used Akismet with the patch from this issue applied. I created the "po" folder myself, to check the warning.

The attached patch should work without producing the warning for each file in the directory. It will only produce the warning for the .module file.

Doug - the check in the previous patches wasn't within the if (substr($filename, -7) == '.module') {....} section and so was being applied to every file.

Cheers,
Stella

Committed.