DROP: when the user adds a content type, base the type on the name using javascript
greggles - February 26, 2008 - 17:26
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | node system |
| Category: | feature request |
| Priority: | normal |
| Assigned: | qbnflaco |
| Status: | duplicate |
Description
When the user adds a content type they must enter the name (human readable) and the type (machine readable). It would be nice if the machine readable type were based on the human readable name and got pre-populated when the mouse focus left the name field.
Things we need:
1. A javascript function that will take a string and reduce it so that it is machine readable format (lowercase letters, numbers, and underscores).
2. When the cursor focus leaves the Name field then the javascript needs to pull that name, send it through the function in #1, and populate the type
The motivation for this is that it reduces work for the user and it makes it easier to understand the set of rules for the machine readable format.
#1
just a question: why does the user even need to enter the machine readable type?
#2
While I see where you are going and it makes some sense, I think we need to give users control of this. In the past we've taken that control away (i.e. cck started that way) and it was then added back because users want control of it.
#3
This is assigned to version 7.x-dev, but as a DROP task would we want it implemented in 6.x or 5.x? Should it be a patch in core or should it be a module like "AutoSuggest node-name?"
#4
@snufkin : for non-occidental languages, you can't always autogenerate a suitable machine name (a-z, _) from the human name.
#5
@yched: thats true I havent thought about this.
It just appeared to me because recently i was introducing Drupal to someone completely new to the CMS, and it seemed completely useless and confusing to give a machine name too.
@greggles: is it a necessary control though? In CCK IMHO all of the controls are important and change behaviour some way, this doesnt really.
And actually if I take what yched said, then is it not possible to do this mapping via JS? Or reversed: if its possible to do it with JavaScript, it should be possible to do it via PHP, automatically.
#6
@cwells: why can't a drop task be for Drupal7?
Since this changes functionality I don't think this would be appropriate for D5 or D6 and it seems awfully small for a contrib module.
#7
A DROP task certainly can be for 7.x, I just want it NOW :). I think this is awesome as an idea, and if there were a contrib module for it, I'd use it on all my sites (existing 5x and new 6x sites).
#8
I claim this task!!
#9
Here's the patch. Many thanks to Demitri for all his help!! A beer for him as soon as he's 21! :D
#10
Eclipse's .project file got added to this patch by mistake.
#11
ok, took out the project file from the patch
#12
Marking back to needs review. :)
#13
It doesn't work in Firefox 2, this is the error output by Firebug:
$("#edit-name", context).val().strtolower is not a functionhttp://localhost/drupal09/modules/node/node.admin.js?E
Line 3
#14
The .strtolower method was changed to .toLowerCase This should now work.
#15
It works now.
However, if you change the MRN (machine-readable name) to something else, it will change back as soon as the HRN loses focus again.
I don't think the MRN should change if it already has a value.
#16
- If you're using 'toLowerCase()' then what does the 'i' regexp flag serve?
- Style: isn't
$('#edit-name', context)redundant?- This code converts "One (two)" to "one__two_". Those superfluous underscores aren't nice.
- This code converts "הכל בסבבה ואני בג'ננה" to "_________________". Ditto.
#17
Rowanw:
It doesn't seem to happen to me. The 'type' only changes when I make a change to the 'name'. Hmm.. a class gets added that should stop it from changing if the js has changed it once. I'm not sure why this isn't working.
mooffie:
I also agree that if there was already something for the name field, it shouldn't be changed by js anymore. Any idea how I can add that into the JS? I have pretty limited js abilities. Can you suggest something to help internationalize it? Also can you suggest a way of avoiding the '__' issue?
Thanks
#18
This patch should do the trick :) (based off qbnflaco's latest patch).
Let me know if there's anything else I can do to help with this :)
#19
No patch. :(
#20
eek, I thought it went through last time. strange…
hopefully it works this time :)
#21
#22
It would be simpler to just do:
replace(/[^a-z0-9]+/g, '_').replace(/^_+|_+$/, ''). This will also remove underscores at the beginning of the name.#23
The last submitted patch failed testing.
#24
Thanks for taking the time to report this issue.
However, marking as duplicate of #471018: Generic pattern/js for hiding machine readable names (applied to menu and content types).
You can follow up on that issue to track its status instead. If any information from this issue is missing in the other issue, please make sure you provide it over there.