The error for "The getID3 PHP library could not be found in sites/all/modules/getid3/getid3." has a link for getID3 going to /admin/settings/@getid3. The t() function is being called incorrectly.

At line 129,

form_set_error($form_element['#parents'][0], t('The <a href="@getID3" target="_blank">getID3 PHP library</a> could not be found in %path.', array('@url' => 'http://www.getid3.org', '%path' => $path)));

could become

form_set_error($form_element['#parents'][0], t('The <a href="@url" target="_blank">getID3 PHP library</a> could not be found in %path.', array('@url' => 'http://www.getid3.org', '%path' => $path)));

but even better would be

form_set_error($form_element['#parents'][0], t('The !getID3 could not be found in %path.', array('!getID3' => l(t('getID3 PHP library'), 'http://www.getid3.org'), '%path' => $path)));
CommentFileSizeAuthor
#1 getid3.notfoundlink2.patch896 bytesaaron
getid3.notfoundlink.patch867 bytesaaron

Comments

aaron’s picture

aaron commented
StatusFileSize
new getid3.notfoundlink2.patch896 bytes

if you still want the _blank target, then just add that to the link attributes. forgot about that, sorry... here it is in this second patch

robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed

Thanks! Don't really need the _blank target, but ah well...

http://drupal.org/cvs?commit=103310

Aaron, would you like CVS access on here to help maintain the project? You probably know the best ways to use GetID3 through your involvement with Embedded Media Field....

aaron’s picture

aaron commented

Sure thing, Rob! Go ahead and add me in. I've been investigating the module anyway, as a path to add better support for local files to Embedded Media Field.

robloach’s picture

robloach
he/him
commented

Done! Feel free to hack at it as much as you want.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.