[D7] Display Suite Meta

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxisholgueras2135833git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Correct link to clone is

git clone --branch 7.x-1-x http://git.drupal.org/sandbox/isholgueras/2135833.git ds_meta

Automated Review

http://pareview.sh/pareview/httpgitdrupalorgsandboxisholgueras2135833git

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

Best practice issues identified by pareview.sh / drupalcs / coder. Please don't

copy/paste all of the results unless they are short. If there are a lot, then post a

link to the automated review and mention that problems should be addressed.

Manual Review

Individual user account

Yes: Follows the guidelines for

individual user accounts

.

No duplication

Not sure. Need to evaluate ds_extra and Viewmode columns modules.: Does not

cause module duplication and

fragmentation.

Master Branch

No: Follows the guidelines for

master branch.

Licensing

Yes: Follows the licensing

requirements

3rd party code

Yes: Follows the guidelines for

3rd party code

.

README.txt/README.md

Yes/No: Follows the guidelines for

in-project documentation

and the

href="https://www.drupal.org/node/2181737">README Template

.

Code long/complex enough for review

Yes: Follows the guidelines

for project length

and complexity.

Secure code

Yes. Checked all fields for XSS attacks. If "no", list

code">security

issues identified.

Coding style & Drupal API usage

1. Do we need changelog.txt in initial commit?
2. Do we need headings where meta view modes are not available?
   
3. There shouldn't be any need to show Meta Display configurations if there are no children display available.
   
4. There are multiple TODOs in install file. Please fix them.
5. Just let me know if there is any need to implement hook_permission? Where this permission 'admin_view_modes' implemented?
   

   /**
    * Implements hook_menu().
    */
   function ds_meta_menu() {
     $items = array();
   
     // Custom CSS classes.
     $items['admin/structure/ds/meta'] = array(
       'title' => 'Meta view modes',
       'description' => 'Define which of this view modes are meta view mode.',
       'page callback' => 'drupal_get_form',
       'page arguments' => array('ds_meta_entity_view_mode_form'),
       'access arguments' => array('admin_view_modes'),
       'type' => MENU_LOCAL_TASK,
     );
   
     return $items;
   }

The starred items (*) are fairly big issues and warrant going back to

Needs Work. Items marked with a plus sign (+) are important and

should be addressed before a stable project release. The rest of the

comments in the code walkthrough are recommendations.

Will play around with this module fully and let you know if I get other issues.

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.