Closed (fixed)
Project:
Advertisement
Version:
5.x-1.x-dev
Component:
adserve.php
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Feb 2008 at 16:04 UTC
Updated:
28 Mar 2008 at 12:32 UTC
I had a problem that ads with maximum clicks and views settings where not being expired. Upon investing I found the adserve_increment() function in adserve.inc and noticed it checked maxviews and maxclicks but neither of these were actually set, in fact $ad only contained the aid. My fix for this was to add
$ad = node_load($ad->aid);
at the top of this function to make sure these two are loaded. A patch with this change is attached, not sure if there's a different way or if this is fixed in another report (couldn't find one).
| Comment | File | Size | Author |
|---|---|---|---|
| adserve.diff | 92 bytes | stevensurowiec |
Comments
Comment #1
jeremy commentedThis appears to be an old bug that was already fixed -- maxclicks and maxviews is available in adserve_increment.
Comment #2
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.