I had a problem that ads with maximum clicks and views settings where not being expired. Upon investing I found the adserve_increment() function in adserve.inc and noticed it checked maxviews and maxclicks but neither of these were actually set, in fact $ad only contained the aid. My fix for this was to add
$ad = node_load($ad->aid);
at the top of this function to make sure these two are loaded. A patch with this change is attached, not sure if there's a different way or if this is fixed in another report (couldn't find one).

CommentFileSizeAuthor
adserve.diff92 bytesstevensurowiec

Comments

jeremy’s picture

Status: Needs review » Fixed

This appears to be an old bug that was already fixed -- maxclicks and maxviews is available in adserve_increment.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.