Remove options to change node author or menu settings

agentrickard - February 28, 2008 - 02:10
Project:Domain Access
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed
Description

The Domain Access module attempts to allow users without the 'administer nodes' permission the ability to edit certain node elements that they are not normally allowed to.

This applies to users with the 'edit domain nodes' permission.

However, the logic inside node_submit() disallows the user from changing the author field. http://api.drupal.org/api/function/node_submit/5

And the logic in menu_nodeapi() disallows the user from changing a menu path. http://api.drupal.org/api/function/menu_nodeapi/5

Not sure how best to address these issues. It may be that they must be removed from the options.

#1

agentrickard - March 15, 2008 - 19:15
Category:bug report» feature request
Status:active» postponed

This has been noted in the UI, but not fixed.

#2

blackdog - August 14, 2009 - 14:02
Version:5.x-1.0» 6.x-2.x-dev

This is still an issue in 6.x unfortunately. I too think it's best to remove those options all together if we can't work around them somehow.

#3

agentrickard - August 14, 2009 - 16:06

I would agree, removal is the only real option, since this is a core issue.

#4

agentrickard - August 14, 2009 - 16:12
Title:Cannot change node author or menu settings» Remove options to change node author or menu settings
Status:postponed» active

Changing title and status. Let's just fix this. I think the publication date applies here too.

#5

blackdog - August 15, 2009 - 11:00
Status:active» needs review

Here's the patch to remove the two options. Don't know if need to change the README as well, it doesn't say anything about authoring or menu settings so it may be fine as is. Needs a changelog entry though.

AttachmentSize
227751-remove-node-options.patch 1.41 KB

#6

agentrickard - August 15, 2009 - 17:05
Status:needs review» reviewed & tested by the community

Looks good. RTBC. No docs changes needed, just a note in the Changelog.

#7

agentrickard - August 17, 2009 - 14:00
Status:reviewed & tested by the community» needs work

Hm. Do we need an update hook for this? To erase the current variable and rest to the proper one?

Probably.

#8

blackdog - August 17, 2009 - 19:17
Status:needs work» needs review

How's this?

AttachmentSize
227751-remove-node-options.patch 2.32 KB

#9

agentrickard - August 17, 2009 - 19:23
Status:needs review» patch (to be ported)

Perfect. Committed to HEAD.

#10

agentrickard - October 31, 2009 - 19:37
Status:patch (to be ported)» fixed

Committed to D5.

#11

System Message - November 14, 2009 - 19:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.