link attributes added to l() incorrectly [#227830]

There are 9 calls to l() across 6 files that add parameters incorrectly. If you pass an html attribute in the $options array without putting it in attributes =>array() the html attribute will be ignored by l().

For example, theme.inc calls:

l($name, 'user/'. $object->uid, array('title' => t('View user profile.')))

But that should be:

l($name, 'user/'. $object->uid, array('attributes' => array('title' => t('View user profile.'))))

The other calls are similarly incorrect.

Comment	File	Size	Author
#8	link-parameters.patch	5.29 KB	johnalbin
#6	link-parameters.patch	6.03 KB	johnalbin
#3	link-parameters.patch	6.47 KB	johnalbin
#1	link-parameters.patch	6.46 KB	johnalbin
	link-parameters.patch	6.35 KB	johnalbin

Comments

Comment #1

johnalbin

they/他

English

Taipei, Taiwan

commented 14 April 2008 at 00:47

Version:

6.x-dev

» 7.x-dev

Status	File	Size
new	link-parameters.patch	6.46 KB

To get more eyeballs, updated patch for D7.

Comment #2

mikey_p commented 30 April 2008 at 01:17

Status:

Needs review

» Needs work

patching file includes/theme.inc
Hunk #1 FAILED at 1552.
1 out of 2 hunks FAILED -- saving rejects to file includes/theme.inc.rej
patching file modules/blog/blog.module
patching file modules/comment/comment.admin.inc
Hunk #1 FAILED at 64.
1 out of 1 hunk FAILED -- saving rejects to file modules/comment/comment.admin.inc.rej
patching file modules/node/node.module
Hunk #1 FAILED at 135.
1 out of 1 hunk FAILED -- saving rejects to file modules/node/node.module.rej

Comment #3

johnalbin

they/他

English

Taipei, Taiwan

commented 30 April 2008 at 15:30

Status:

Needs work

» Needs review

Status	File	Size
new	link-parameters.patch	6.47 KB

Thanks for the review, Michael!

I should have checked the patch before asking for reviews on IRC. The code style change for concatenation broke the patch. Doh!

Re-rolled.

Comment #4

mikey_p commented 1 May 2008 at 17:47

Status:

Needs review

» Reviewed & tested by the community

Tested, and reviewed the code, straightforward.

Comment #5

dries commented 2 May 2008 at 15:12

Version:

7.x-dev

» 6.x-dev

Good catch. Committed to CVS HEAD. Seems like it is easy to make mistakes ... wonder if we can do something about that.

Changing version to Drupal 6 for Gabor to review.

Comment #6

johnalbin

they/他

English

Taipei, Taiwan

commented 2 May 2008 at 15:46

Status	File	Size
new	link-parameters.patch	6.03 KB

#229817: Wrong use of l function in theme_username broke the DRUPAL-6 version of this patch. Just had to remove one section from the patch to get it working.