It's a very good module, thanks for that! Ready for drupal 6?

CommentFileSizeAuthor
#8 drush-6.x-228044-8.patch8.7 KBwebchick
#7 drush-6.x-228044-7.patch8.36 KBwebchick
#4 drush-6.x-228044-4.patch7.38 KBwebchick

Comments

robloach’s picture

robloach
he/him
commented

Subscribing.

jacauc’s picture

jacauc commented

subscribing

moshe weitzman’s picture

moshe weitzman commented

I just did some initial eperiments and drush module itself works just by adding to the .info file for core = 6.x. The various submodules need minor updates. This is going to be an easy port. I'll do it soon if noone else does.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review
StatusFileSize
new drush-6.x-228044-4.patch7.38 KB

I haven't tested this extensively, but it was enough to get drush pm install working. Update Status module's naming schemes have changed some since its inclusion into core.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Active

Tested SimpleTest integration and that appears to also be working, except it'll constantly report a failure thanks to http://drupal.org/node/87310#comment-778899.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Active » Needs review

Oops. Didn't mean to set back to active.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new drush-6.x-228044-7.patch8.36 KB

Missed a couple of function renames in drush_pm.module.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new drush-6.x-228044-8.patch8.7 KB

Regarding comment #5, Moshe suggested faking the variable in drush.php, as we do for other bootstrap.inc variables it expects. I did so, and now this is no longer barking unrelated errors while running SimpleTest.

moshe weitzman’s picture

moshe weitzman commented
Title: D6? » D6 - port pm update and dblog
Status: Needs review » Active

I committed this. Thanks webchick.

A couple flaws we still need to fix
- pm update not listing all projects and likely not working
- watchdog show command does not account for variables system in watchdog(). ideally we rename these commands to dblog.

Setting to active for those.

moshe weitzman’s picture

moshe weitzman commented
Title: D6 - port pm update and dblog » update watchdog show command for D6

i fixed pm update. only watchdog is outstanding now.

theemstra’s picture

theemstra commented

Is it fixed yet?

moshe weitzman’s picture

moshe weitzman commented
Status: Active » Fixed

Yes - fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.