As title. Remove the use of %%. Please refer to http://php.net/pdo#pdo.prepared-statements

CommentFileSizeAuthor
#11 ansi-cache.inc-1223534171.patch2.97 KBhswong3i
#10 ansi-cache.inc-1223218966.patch3.01 KBhswong3i
#7 ansi-cache.inc-1223188020.patch1.78 KBhswong3i
#5 ansi-cache.inc-0.3.patch1.8 KBhswong3i
#3 ansi-cache.inc-0.3.patch1.79 KBhswong3i
#2 ansi-cache.inc-0.3.patch1.69 KBlilou
#1 ansi_pdo-cache.inc-0.2.patch1.95 KBobsidiandesign
ansi_pdo-cache.inc-0.1.patch1.46 KBhswong3i

Comments

obsidiandesign’s picture

obsidiandesign commented
StatusFileSize
new ansi_pdo-cache.inc-0.2.patch1.95 KB

Rerolled against latest head. Applies & works correctly with both MySQL and PostgreSQL. Simpletests run successfully for cache module. +1

lilou’s picture

lilou commented
Title: Patch for ANSI and PDO compatible: cache.inc » Patch for ANSI compatible: cache.inc
StatusFileSize
new ansi-cache.inc-0.3.patch1.69 KB

PDO fix by #225450: Database Layer: The Next Generation.

Reroll.

hswong3i’s picture

hswong3i commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new ansi-cache.inc-0.3.patch1.79 KB

Just reroll without change. Apply cleanly.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Needs work

Please rewrite those using db_delete.

hswong3i’s picture

hswong3i commented
Status: Needs work » Needs review
StatusFileSize
new ansi-cache.inc-0.3.patch1.8 KB

Reroll with db_delete().

c960657’s picture

c960657 commented
Status: Needs review » Needs work

Patch no longer applies to HEAD.

hswong3i’s picture

hswong3i commented
Assigned: Unassigned » hswong3i
Status: Needs work » Needs review
StatusFileSize
new ansi-cache.inc-1223188020.patch1.78 KB
c960657’s picture

c960657 commented

Looks good to me.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

In order to have consistency we have agreed that you should write

db_delete($table)->condition('expire', CACHE_PERMANENT, '<>')->condition('expire', $cache_flush, '<=')->execute();

Like so

db_delete($table)
  ->condition('expire', CACHE_PERMANENT, '<>')
  ->condition('expire', $cache_flush, '<=')
  ->execute();
hswong3i’s picture

hswong3i commented
Title: Patch for ANSI compatible: cache.inc » TNG DB + ANSI compatible: cache.inc
Status: Needs work » Needs review
StatusFileSize
new ansi-cache.inc-1223218966.patch3.01 KB
hswong3i’s picture

hswong3i commented
Title: TNG DB + ANSI compatible: cache.inc » [TNGDB + ANSI]: cache.inc
Category: bug » task
StatusFileSize
new ansi-cache.inc-1223534171.patch2.97 KB

Should we have more discussion for this issue, or move it as RTBC?

dries’s picture

dries commented
Status: Needs review » Fixed

This is RTBC. Committed to CVS HEAD. Thanks.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.