When activating cache in "normal" mode, site is unaccessible because of call to undefined function drupal_add_js()

Posted by tdebruyn on February 29, 2008 at 11:09am

Issue Summary

When activating cache in "normal" mode (most probably in "aggressive" mode too), the site becomes unaccessible for unregistered users with the following message:

"Fatal error: Call to undefined function: drupal_add_js() in /home/user/www/modules/yui/yui.module on line 33".

There was a similar problem in the gallery module which was fixed in 5.x-2.2: http://drupal.org/node/224598

Comments

#1

Posted by bakyildiz on March 13, 2008 at 8:17pm

Assigned to:

Anonymous

» bakyildiz

Thanks for reference. Please try the yui version 2.3. Please feed back.

#2

Posted by iwankgb on March 17, 2008 at 9:59am

I've just updated yui and yui_menu, enabled normal caching and everything seems to be fine :]

#3

Posted by bakyildiz on March 17, 2008 at 6:19pm

Version:	5.x-2.2	» 5.x-2.3
Status:	active	» fixed

#4

Posted by bakyildiz on March 20, 2008 at 6:42pm

Version:

5.x-2.3

» 6.x-1.1-1

Fixed. Use yui 6.x-1.1-1 and yuimenu 6.x-1.1-1

#5

Posted by Anonymous (not verified) on April 3, 2008 at 6:54pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

#6

Posted by mustafau on June 5, 2008 at 9:05am

Version:	6.x-1.1-1	» 5.x-2.0-dev
Status:	closed (fixed)	» needs review

I think this issue was fixed in a wrong way. You should not include common.inc inside a module file. That will lead to performance issues. Instead you should read suggested fix at http://api.drupal.org/api/function/hook_init/5.

#7

Posted by bakyildiz on June 7, 2008 at 5:19pm

One point is not clear in my mind. Should i remove the yui_init() function and move the 2 lines to yui_menu() like as follows ? Should it before the if($may_cache) line or after ? By the way many thanks for your advanced support.

<?php


function yui_menu($may_cache) {
  $skin = variable_get('yui_skin', 'yui-skin-sam');
  drupal_add_js("if (Drupal.jsEnabled) { $(document).ready(function() { $('body').addClass('$skin'); } ); };", "inline");  
  $items = array();
  if ($may_cache) {
    $items[] = array(
  ...
  ...
?>

#8

Posted by mustafau on June 7, 2008 at 6:00pm

<?php
function yui_menu($may_cache) {
  $items = array();
  if ($may_cache) {
    $items[] = array(
  ...
  }
  else {
    $skin = variable_get('yui_skin', 'yui-skin-sam');
    drupal_add_js("if (Drupal.jsEnabled) { $(document).ready(function() { $('body').addClass('$skin'); } ); };", "inline"); 
  }
  ...
?>

#9

Posted by bakyildiz on June 8, 2008 at 7:36am

Version:	5.x-2.0-dev	» 5.x-1.x-dev
Status:	needs review	» fixed

Fixed in 5.x-1.x-dev and will ready in next release.

#10

Posted by Anonymous (not verified) on June 22, 2008 at 7:42am