Hello, Very great module!! Any ideas to the magical (:-)) port to Drupal 6?

Thanks,

Thom

Comments

jredding’s picture

when magical patches come in... My suggestion is to grab the tarball, grab the coder module and take a stab at it. I think you'll find it easier than you think.

My focus right now and for at least the next month is going to be on the 5 module (sorry) as there are some bug fixes, feature requests and simple redesigns already requested.

Take a stab at it, at the very least you'd learn something in the process

theemstra’s picture

Aha, aha, ow

I understand, 5? ;-(

Much suc6!,

Thom

Fanaile’s picture

*subscribing*

theemstra’s picture

Do you have any planning for Drupal 6 for now?

kbahey’s picture

We are waiting for patches ffrom the community.

If you want to do that, then use the 5.x-3.x-dev as a starting point, not 3.3.

theemstra’s picture

Ok,

No Drupal 6 in planning?

jredding@drupal.org’s picture

Unfortunately, for you, the active developers for this module are not actively building D6 sites thus there is no driving motivation to get this onto 6 other than pure philanthropic reasons. I know everyone working on UP wants it on 6, really we do, but we have more pressing needs on 5 are the direction right now. Patches to upgrade to 6 are always welcome and definitely more welcome the the obvious stating of "I want it on 6", we also want it on 6.

Not trying to be harsh but continually posting that you want it doesn't help move the process any further.

theemstra’s picture

Version: 6.x-1.x-dev » master
Status: Fixed » Active

Ok,

Thanks for your time,

Thom

btmash’s picture

Hi,

I'm currently in the process of porting over userpoints to 6.x (at the very least, userpoints and userpoints basic will be ported over). As I go along, I'll have a few questions for those that know more about the userpoints module:

1) Does the userpoints module require taxonomy? I ask because there are links to go to the admin/user/userpoints section which seem to require taxonomy be enabled (or I get errors that taxonomy_save_vocabulary and taxonomy_get_vocabulary can't be found).

2) What would be the correct function now for taxonomy_get_vocabulary - the closest match I can find in D6 is taxonomy_get_tree or somesuch.

kbahey’s picture

Taxonomy is used by userpoints, but it is not mandatory. We have a check for that in the places that need it.

As for the function, you should use this new one http://api.drupal.org/api/function/taxonomy_vocabulary_load/6

t3r0’s picture

BTMash: I've also just started porting Userpoints to Drupal6.. I'll post a patch asap here to avoid any more duplicate work...

Work done so far:

- .install file
- .info files
- more or less working userpoints.module (need much more testing, put everithing seems to be working)

t3r0’s picture

StatusFileSize
new26 KB

Ok here's the patch.. It's just a cvs diff of all the files not the smartest way but anyway... :)

So how should we continue from here?

Note that this patch is work in progress...

btmash’s picture

Funny we're both in pretty much the same spot (based on looking at your diff) Your info files look good (though the userpoints views dependencies should be separated out by line). - I had finished off the install/uninstall/schema hooks and had the userpoints pretty much working with userpoints basic.

I think the best way might be to do it on the file by file basis - I'll fill in some of the gaps you have in your install file (I had not tackled the userpoints updates functions so thanks for filling those in ^_^) and we can go from there?

I show my set of diffs for each file separately.

-BTM

kbahey’s picture

Version: master » 5.x-3.x-dev

@BTMash and t3r0

First, I want to thank you for this effort. Much appreciated.

Second, please make sure that you are not working from HEAD. Rather from the DRUPAL-5--3 CVS tag. Otherwise lots of work in 5.x-3.* will not be reflected in what you will do.

As for the patch, doing a "cvs diff -uF^f" inside the userpoints directory is the correct way to do it. One patch for all the changes, as long as the patch is not too big.

Finally, once you have a working patch, or a patch that others can work from and add to, then we need testing to start before I create a 6.x-1.x-dev release.

btmash’s picture

StatusFileSize
new31.3 KB

I wasn't sure which version I was using at the time so I started over on the DRUPAL-5--3 CVS tag. I used most of the install portion of what t3r0 did and made some modifications. You're both welcome to take a look. I'm mostly there but I ran into the same issue I did when I first asked if userpoints requires taxonomy. When I go to the admin/user/userpoints page, I get:

Fatal error: Call to undefined function: taxonomy_get_vocabulary() in /Users/ashokmodi/Sites/zimmertwins6/sites/all/modules/userpoints/userpoints.module on line 1709

The two areas where there are no checks for taxonomy module existing are userpoints_get_vid and userpoints_get_categories.

btmash’s picture

StatusFileSize
new31.8 KB

I went back to the userpoints_get_categories function and added a module_exists() check before trying to load taxonomy terms and the pages now seem to work. Attaching the new patch this time around.

kbahey’s picture

Version: 5.x-3.x-dev » 6.x-1.x-dev
Status: Active » Fixed

BTMash and t3r0, thank you!

The tarball for a 6.x-1.x-dev branch should be here in a few hours.

http://drupal.org/node/239092

You can checkout the tag DRUPAL-6--1 for further refinement, and open new issues for future patches.

Anonymous’s picture

Version: master » 6.x-1.x-dev
Status: Active » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.