[Meta] Standardize entity route names

Holy crap we have a lot of entities... I'll make separate issues shortly unless someone wants to beat me to it. :-)

I got bored on the plane back from Design4Drupal so ploughed through these. :-) We'll see if the tests actually pass.

The only one remaining, I think, is EntityTest, which as noted in its issue has a number of subclassed entities that do weird things with their links.

If there's a links-using entity I forgot, please add it to the list (and file a patch!)

As a result of this effort we now have inconsistent route names. Some are entity.$entity_type.$something, some aren't.

image.style_add:
  path: '/admin/config/media/image-styles/add'
  defaults:
    _entity_form: image_style.add
    _title: 'Add image style'
  requirements:
    _permission: 'administer image styles'


entity.image_style.edit_form:
  path: '/admin/config/media/image-styles/manage/{image_style}'
  defaults:
    _entity_form: image_style.edit
    _title: 'Edit style'
  requirements:
    _permission: 'administer image styles'


entity.image_style.delete_form:
  path: '/admin/config/media/image-styles/manage/{image_style}/delete'
  defaults:
    _entity_form: 'image_style.delete'
    _title: 'Delete'
  requirements:
    _permission: 'administer image styles'


image.style_list:
  path: '/admin/config/media/image-styles'
  defaults:
    _entity_list: 'image_style'
    _title: 'Image styles'
  requirements:
    _permission: 'administer image styles'

See how the add and list route names don't match the pattern? Yes, it's because that one is not semantically important, but at a glance it looks inconsistent, and it's bad DX having to think about and explain it.

This is a stepping stone toward most of the entity routes being auto-generated anyway, so any visual inconsistency in the routing.yml file will go away in time.

The last one left #2314889: Standardize entity_test entity route names
So closing the meta

:( https://www.drupal.org/node/2327373

Now the last one is #2327373: Standardize view entity route names

We also forgot about menu_ui_entity_type_build()

@dawehner good catch!
Questions:
1) entity.menu_link_content.add_form is defined in menu link content module but used in menu (same we have for term-add)
2) \Drupal\menu_link_content\Form\MenuLinkContentDeleteForm::getCancelUrl() point to menu ui route but dependency is wrong

Fixed the test

EDIT: maybe better leave the name of contextual link as it was?

+1

RTBC once it is green.

1. +++ b/core/modules/menu_ui/menu_ui.links.action.yml
   @@ -1,12 +1,12 @@
   -menu_ui.menu_add:
   -  route_name: menu_ui.menu_add
   +entity.menu.add_form:
   +  route_name: entity.menu.add_form
      title: 'Add menu'
   

   Its not your fault, so +1

2. +++ b/core/modules/menu_ui/menu_ui.links.contextual.yml
   @@ -1,4 +1,4 @@
   -menu_ui_edit:
   +entity.menu.edit_form:
      title: 'Edit menu'
   -  route_name: 'menu_ui.menu_edit'
   +  route_name: 'entity.menu.edit_form'
   

   I am fine with that change!

Filed follow-up for bug #2328883: menu ui route used in menu link content

It's green.

There we go.

+++ b/core/modules/menu_ui/menu_ui.links.action.yml
@@ -1,12 +1,12 @@
+entity.menu_link_content.add_form:
+  route_name: entity.menu_link_content.add_form

+++ b/core/modules/menu_ui/menu_ui.module
@@ -74,10 +74,10 @@ function menu_ui_entity_type_build(array &$entity_types) {
+    ->setLinkTemplate('delete-form', 'entity.menu.delete_form')
+    ->setLinkTemplate('edit-form', 'entity.menu.edit_form')
+    ->setLinkTemplate('add-link-form', 'entity.menu_link_content.add_form');
 }

Sorry but this simply can't work.

On top of that I recommend here to fix action module and contact module directly as well. https://www.drupal.org/node/2281645#comment-9102521 contains those changes already as well.

makes sense to fix action and contact.
please elaborate #20 - I can;t get what's wrong

Fixed #20 & #21

I think we got 'em all this time? :-)

Committed to 8.0.x.

Just a question about this issue: the change record notice is still a draft, any reason to not publish it ?

published, also field_ui could update some routes in followup

Follow-up is #2346883: Standardize field_ui entity route names