In page "Recent log entries" (/admin/reports/dblog):

The journal text-entry form appears close to the top left of the page, on top of the log entries table of the page.

Also: It cause the log table to be shifted to the right.
(shifted by the text "If not empty, contents of this field will be logged to the system journal.")

CommentFileSizeAuthor
#1 drupal6.dblog-css.patch1.08 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: Too ambiguous stylesheet in dblog.css » entry form on top of messages in "Recent log entries"
StatusFileSize
new drupal6.dblog-css.patch1.08 KB

Actually, no, it's dblog.css that's causing all form items to float: left, which is not only slower, but also senseless, because only the form items in the filter form are styled.

[removed my ugly, blindfolded comment]

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Title: entry form on top of messages in "Recent log entries" » Too ambiguous stylesheet in dblog.css
Project: Journal » Drupal core
Version: 6.x-1.0 » 6.x-dev
Component: User interface » dblog.module
Status: Active » Needs review

Description
If a contrib module is adding fields to the form on the page "Recent log entries" (admin/reports/dblog), the styles for the form items of the "Filter log messages" fieldset are applied to all fields of the whole form. This happens because the CSS selector in dblog.css is too ambiguous.

Attached patch fixes this bug.

drdrup’s picture

drdrup commented

I've tried the patch: Magic!! Works perfectly!!

Thanks for solving it so fast!!

maartenvg’s picture

maartenvg commented
Title: entry form on top of messages in "Recent log entries" » Too ambiguous stylesheet in dblog.css
Version: 6.x-dev » 7.x-dev
Status: Needs review » Reviewed & tested by the community

This is still the case, let's first get in D7, then port it back to D6 and perhaps D5 as well.

Patch works flawlessly for D7. Given the triviality of sun's patch, I mark this RTBC.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community
sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

meh... already done: http://drupal.org/cvs?commit=137545

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.