Closed (fixed)
Project:
False Account Detector
Version:
5.x-1.3
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
1 Mar 2008 at 04:45 UTC
Updated:
30 Oct 2008 at 11:02 UTC
I ran the coder(eview) module and fixed the things it said except for the following:
false_account.module
* severity: normal Include the CVS keyword $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ in each file. This should be in the format // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ or // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ (Drupal Docs)
* severity: critical Line 51: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
if ($may_cache) {
* severity: critical Line 52: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
* severity: critical Line 60: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
* severity: critical Line 69: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
* severity: critical Line 78: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
* severity: critical Line 87: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
* severity: critical Line 96: The menu system has been completely over-hauled in 6.x. (Drupal Docs)
$items[] = array(
false_account.install
* severity: normal Include the CVS keyword $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ in each file. This should be in the format // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ or // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ (Drupal Docs)
* severity: critical Line 8: A new schema API has been added in 6.x (Drupal Docs)
switch ($GLOBALS['db_type']) {
Explanation: This patch caused changes to the format of hook_install(), hook_uninstall(), and hook_update_N(). No longer are switch statements done on $GLOBALS['db_type']; instead, use the variety of schema API functions to perform table manipulation.
* severity: critical Line 11: Use the new Schema API to create and drop tables rather than db_query() (Drupal Docs)
$created = db_query("CREATE TABLE IF NOT EXISTS {false_accounts} (
| Comment | File | Size | Author |
|---|---|---|---|
| false_account.diff | 7.79 KB | reikiman |
Comments
Comment #1
nunoveloso commentedVersion 2.0 just ported to D6.
Comment #2
nunoveloso commentedComment #3
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.