I ran the coder(eview) module and fixed the things it said except for the following:

false_account.module

    * severity: normal Include the CVS keyword $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ in each file. This should be in the format // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ or // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ (Drupal Docs)
    * severity: critical Line 51: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

        if ($may_cache) {

    * severity: critical Line 52: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

          $items[] = array(

    * severity: critical Line 60: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

          $items[] = array(

    * severity: critical Line 69: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

          $items[] = array(

    * severity: critical Line 78: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

          $items[] = array(

    * severity: critical Line 87: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

          $items[] = array(

    * severity: critical Line 96: The menu system has been completely over-hauled in 6.x. (Drupal Docs)

          $items[] = array(

false_account.install

    * severity: normal Include the CVS keyword $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ in each file. This should be in the format // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ or // $Id: coder_comment.inc,v 1.1.4.5 2008/02/28 11:52:07 douggreen Exp $ (Drupal Docs)
    *  severity: critical Line 8: A new schema API has been added in 6.x (Drupal Docs)

        switch ($GLOBALS['db_type']) {

      Explanation: This patch caused changes to the format of hook_install(), hook_uninstall(), and hook_update_N(). No longer are switch statements done on $GLOBALS['db_type']; instead, use the variety of schema API functions to perform table manipulation.
    *  severity: critical Line 11: Use the new Schema API to create and drop tables rather than db_query() (Drupal Docs)

            $created = db_query("CREATE TABLE IF NOT EXISTS {false_accounts} (

CommentFileSizeAuthor
false_account.diff7.79 KBreikiman

Comments

nunoveloso’s picture

Assigned: Unassigned » nunoveloso
Status: Active » Closed (fixed)

Version 2.0 just ported to D6.

nunoveloso’s picture

Status: Closed (fixed) » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.