Port to drupal 6.0
reikiman - March 1, 2008 - 05:01
| Project: | Email Verification |
| Version: | 5.x-2.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | dbr |
| Status: | closed |
Description
I ran the coder module and did everything it said. The module is ported and installs and can be enabled and the site doesn't crash afterward.
| Attachment | Size |
|---|---|
| email_verify.diff | 3.57 KB |
#1
I have done a port of Email Verify that is improved from the above with comments and the use of page handlers for a smaller module.
PHP memory usage is around 8900 bytes for this Drupal 6 port.
#2
This module is not causing any problems since I've installed it, but it also hasn't report any non-existing emails yet.
In any case, can we have some Drupal 6 version officially published? Probably it would also contribute to the popularity and better testing...
#3
LUTI (or other users), could you test the ported module by entering wrong emails yourself?
#4
erm it does detect wrong emails.... i do not understand what you mean about not reporting since only the user who enters the wrong email will get the error, i think you should just try it out yourself... all i can say is that it works fine on my install
#5
I've entered some non-existing user @ my domain (my mail server - postfix) while registering a dummy test user, and nothing was reported... I don't know if postfix shall compalin or not in such a case (and, where to set exactly what - generally, need a setting that everything not dispatched to existing users is forwarded to me as a postmaster, just for the case of typos while sending mails to us...).
I also wouldn't mess too much with my mailer as I don't have too much time these days, and really wouldn't like to break something (it is a bit complicated setup, but I've done all that about 2 years ago and haven't touched anymore after...).
I've just reported that no errors was logged (I have this module installed for some weeks now), nor I've noticed any other issues related to it.
#6
BTW, it would be good to have an option (maybe as a setting, so admins can choose weather to use it or not) that any wrong email detected is logged (with details, what was typed and which part shall be wrong and why) - this would help webmaster to see what is going on at his site:
- if some wrong email addresses are actually detected
- if there are any issues as good addresses being blocked
#7
I'm unable to delete user with invalid mail address. There ist still message that e-mail is invalid. User was added before module was enabled.
#8
I released a version for 6.x, based on atuyo60's version. Thanks to him and reikiman for their contributions!
If you find issue with this version, please file separate reports.
#9
#10
what's new in this realease i can't see any changes.. I made some changes for myself:
line 34:
// timeout to 30 sec. some smtp servers are using delay..$connect = @fsockopen($smtp, 25, $errno, $errstr, 30);
line 90:
// greylisted addresses should by accepted.if (ereg("(G|g)reylist", $to)) {
// This server does not like us, accept the email address
// greylisting in actin
watchdog('email_verify', "Could not verify email address at host $host: $to");
return;
}
#11
Hi Jozef,
This task was about the port to drupal 6.x, which was done. There was no other major change than to make it work with drupal 6.
Could you please post your proposed changes in separate tasks. I think there is already an open task about greylisting, so you should post your proposal there, where it can be compared with the previous proposal and discussed, so we can choose the best solution.
Thanks for your contribution!