I can't seem to get this to work with Adsense, I guess its not possible being Javascript inside Javascript?

Comments

neuraxon77’s picture

neuraxon77 commented

Can the option for a flat file to be served be added rather than always embeddeding them in Javacript so I can Include Adsense and other Javascript ads in my banner list? Doesn't matter if those clicks don't get counted Google does that for me...

Thanks!

jeremy’s picture

jeremy commented

The javascript is what makes it possible for the banner module to display a different ad each time the page is loaded, even when cached.

Yes, I could add functionality to configure a banner group so that it is static (ie, only allows one banner. That banner could then be the adsense javascript...)

I'll look into this when next month -- I'm unable to do any Drupal development until that time.

Michael Acord@www.simplemoneymanagement.info’s picture

Michael Acord@www.simplemoneymanagement.info commented
Component: Banner Ads » Text Ads

I would like to second that request. Javascript text banners would be wonderful.

dan_aka_jack’s picture

dan_aka_jack commented

Yes, support for adsense would be wonderful!

Thank you for all your work - I'm sure it's not easy looking after a module that gets as much use as this one!

Thanks,
Jack

dan_aka_jack’s picture

dan_aka_jack commented

Hi,

I've written a patch to remove JavaScript for banner ads:

Turn off JavaScript when it's not needed

With a bit of work this patch might work for Adsense text ads.

wulff’s picture

wulff commented

Adsense support is not at the top of my todolist, as the adsense module already seems to have that functionality covered.

If more people can test dan_aka_jack's no-javascript patch, that might be a workable solution.

red_eye-at-patentlystupid.com’s picture

red_eye-at-patentlystupid.com commented

wulff,

I hope you will reconsider this perhaps. Here is my thoughts.

While the adsense module does help with adsense its still limited in what it supports. For example Google just released new referal units and AFAIK there isnt support for any of the Referal units in the adsense module yet.

The adsense module while handy still needs manual upades for each ad type Google adds and that means waiting for it to happen which as you know yourself can take time because all the developers are so busy. I think it would be very handy if there was a way to create 'banners' that were really the script that Google gives you to paste since things like the referal links could be handled in a rotating fashion very easily through the banner module. Plus putting adsense support into the banner module would allow us to keep track of and handle all of our advertisng through the same module rather than having two that have to be handled and manipulated seperately.

wulff’s picture

wulff commented

The latest version of my banners-as-nodes update supports adsense banners with some minor extra work.

If you would like to test it, please let me know and I'll post a tarball.

wulff’s picture

wulff commented
Status: Active » Closed (fixed)

Marking as closed since the banner module has been abandoned.