OK, I'll call this a feature request. Bug, feature, bug, at this time of night, I can't tell.
The problem or issue I am trying to point out goes something like this:
An admin user given access to domain conf (for their own domain) (which is what I want) for a subdomain may, in some cases, go to the "site settings" area for the site, and, once there, for instance, change the homepage.
At least on our installs, this will change the homepage for the main install site, not their subdomain.
Equally, they may go to "themes" and change the theme, thinking this will change the theme for their site. It will not-- but it will change the main site.
Ditto frontpage module, though that is another issue.
I understand development-- let me tell you about running SmallTalk-82 on a Sun 1 someday-- and I can create work-arounds -- but IMH(umble) opinion this UI behavior is sub-optimal. If we're using domain access, ideally, the "site settings" and "theme" settings on the modules configuration page should change those settings for whatever site you are on, not some other site, or take you to the appropriate configuration pages in Domain access, with, perhaps, a little explanation of what went on.
And one should not fdsk after midnight, or 3am, or whatever.
Anyway, not a big deal, but that seems the ideal behavior for me (ditto frontpage: or at least, if frontpage is installed, an install of domain access should uninstall frontpage, and explain why).
Idealism is, however, so impractical. So don't mind me. What do others think?
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | domain_warning.patch | 5.09 KB | agentrickard |
Comments
Comment #1
agentrickardrc4 is no longer supported.
I still don't quite understand your reasoning. Here's why.
-- Settings for the Primary domain (domain 0) are still configured via normal forms.
-- Settings for subdomains are optional. If you don't use Domain Conf or Domain Theme -- or do not set them for a specific domain, they simply inherit the values from the base install.
Is your primary domain not the same as the base install for your site?
The issue is the {variables} table in most cases. There is one {variables} table, administered normally. Domain Conf allows the selective override of certain elements of this table on a per-domain basis.
Thinking about it -- it may just be a question of training your users. How many people do you allow to configure domains on your site?
It may be possible to allow the behavior that you expect -- it is also possible to display messages (and we do in some cases) that tell users what happens when certain forms are being used.
I suspect this issue will stay open for a while, as I'd like to know what other users think.
Comment #2
agentrickardClosed for lack of interest.
Comment #3
1kenthomas commentedWe've actually been over this issue in-house a couple of times since the previous post(s).
I'm not sure from the above you've used the module in enough settings to understand the numerous inconsistencies in behavior or use cases.
The current behaviors are simply backwards. I don't care how many times you tell users that they shouldn't go to theme settings on a subdomain, if they're in a hurry, etc, they're going to make the mistake.
This is an instance of the classic UI error of having a switch which lets you set the behavior of the rudder on a plane to be either right=move rudder right, or right=move rudder left. When you do this, people crash planes because they forget and push the stick to the right when it's been set to the opposite-- and sometimes they don't forget, the mechanic or previous pilot does.
It's just common sense to assume that domain theme settings in a CP is going to affect the domain you're using. If it doesn't do this, then at the very least there should be a big warning sign saying something like "you're on a subdomain, please proceed to domain conf settings [@link] /admin/...] if you wish to change..."
In short, this is a bad, unintuitive UI. "Lack of interest," smack of interest, call it what you want, it's done wrong.
Comment #4
agentrickardPlease do not make personal assumptions when trying to state your case. It is insulting.
I closed this issue because no one seconded your suggestion, which leads me to believe that you are the only person (or group) who feels this way.
If you implement hook_domainwarnings(), you can put a warning message on any form that you like -- see API.php for documentation.
A patch to implement hook_domainwarnings() in Domain Theme -- and perhaps to move the function into core Domain, so that it works for all modules, would be worth review.
Comment #5
agentrickardAnd here is the above patch. I do like the idea of moving these warnings out of Domain Conf.
To enable this for the frontpage module -- which I do not recommend using -- you would need to implement hook_domainwarning() separately. You can also use hook_domainconf() to add additional elements to the domain-specific configuration pages.
Comment #6
agentrickardComment #7
Nepherim commentedI'm a new Drupal user, and support the reasoning of 1.kenthomas UI statement. It took me a little while to realize that I had to use the Domain-Theme menu to change the theme on the current domain, and that the 'normal' theme menu changed Site0. I certainly assumed that the 'normal' theme menu would affect the currently selected domain.
Comment #8
agentrickardIs that a review of that patch?
Comment #9
Nepherim commentedNo, it was meant to be a comment on the OP.
Comment #10
agentrickardWell, the theme rules follow the rules for every other "special" domain setting. So my instinct is to go with the patch -- which simply provides a warning that the form needs to be entered from the main domain. This doesn't seem like a major issue to me, but I've never been bitten by it.
Comment #11
agentrickardI have refactored the warnings, and added warnings to additional forms. Committed to 5.x branch.
Comment #12
agentrickardFixed in HEAD.
Comment #13
agentrickardIf you want this to wok with non-core modules, you need to implement the following hook in a custom module file.
Comment #14
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.