alt_login integration with masquerade and user_import
espie - March 2, 2008 - 10:35
| Project: | Alternate Login |
| Version: | 5.x-1.8 |
| Component: | Miscellaneous |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I've written small patches for masquerade and user_import, they're listed on their respective project pages.
The user_import patch, in particular, is about two weeks old by now ? not sure whether the project is still active, nor what should be done for an orphaned project.
#1
what is the purpose of this issue? i'm confused.
#2
Trying to figure out who I should talk to to get things moving.
Obviously, the other patches are `cross-project', between alt_login and user_import/masquerade.
So, who's in charge ? especially if I can't seem to get anyone `active' on the user_import front...
#3
i don't generally like to put custom code in my modules that applies specifically to other contrib modules -- i think for the most part that's sloppy coding.
ususally cross-module communication is done via the hook system, so i would look at that. i'd be willing to consider adding a hook to alt_login to expose the module's information to other modules -- not sure if that would help or not.
#4
then go have a look at the stuff needed to get masquerade and user_import to work seamlessly with alt_login.
As far as user_import goes, I don't see any way but to make it *aware* of alt_login. There's no infrastructure to say `oh, there's extra user information. please import it as well'.
As far as masquerade goes, well... either alt_login is a hack, or it isn't. I don't know the drupal hook system all that well, but if login through alt_login was transparent, masquerade would work without a patch. As it is, it doesn't.
After looking a bit over alt_login, hooking on the login form does not seem to be too nice. It should be somewhere deeper, like, when you call user_load(name => alt_login), then it should just work (and return a user with the real name set... and then even core will be disturbed a bit).
But then... what do I know ? I'm just trying to get alt_login to work as transparently as possible. If you think the `patch other modules to make things work' is the bad approach, at least have a look, and suggest a cleaner one...
#5
as i mentioned in #3, i'm happy to review a patch for this module which makes a sensible improvement. i don't have an interest in exploring patches for other modules to increase interoperability.
also, using FAPI is a sensible place to hook in to perform the login conversion. i have no problem implementing it elsewhere if it results in superior functionality. feel free to submit a patch for that if you like -- as it stands, the module works fine for my needs, so i doubt i'll make that change on my own.
#6
doesn't look like this ever went anywhere. feel free to reopen if you have a patch to show me... ;)
#7
Automatically closed -- issue fixed for 2 weeks with no activity.