PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT. [#22911]

Comment	File	Size	Author
#13	drupal-head-lock_0.diff	2.82 KB	Cvbge

#11	drupal-head-lock.diff	2.82 KB	Cvbge

#7	locks_1.diff	2.81 KB	Cvbge

#5	locks_0.diff	2.8 KB	Cvbge

#4	locks.diff	2.91 KB	Cvbge

Comment #1

kinai CreditAttribution: kinai commented 15 May 2005 at 15:19

Title:

PG_QUERY ERROR

» PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT.

The SQL Command : LOCK TABLES like used in bootstrap.inc is only specified for MySQL, not for PostgreSQL.
The UNLOCK TABLES SQL command is not implemented in PostgreSQL.

Someone could solve this problem ?

Thanks,
Kinaï

Log in or register to post comments

Comment #2

intel352 CreditAttribution: intel352 commented 28 May 2005 at 23:34

this issue still exists, i've verified it on a fresh cvs install w/ pgsql 8

Log in or register to post comments

Comment #3

intel352 CreditAttribution: intel352 commented 28 May 2005 at 23:39

i fixed the problem in my installation, by changing the syntax to:

LOCK TABLE {cache}

it's table, not tables. and i dropped the 'write' bit.

furthermore, pgsql does not support the UNLOCK command, so i had to comment the unlock tables command. unless there are more lock/unlock commands elsewhere in the code, this works fine for me.

according to pgsql docs, UNLOCK is automatically performed at transaction end, which is why there is no such command.

Log in or register to post comments

Comment #4

Cvbge CreditAttribution: Cvbge commented 19 August 2005 at 11:29

Status:

Active

» Needs review

File	Size
locks.diff	2.91 KB

The patch adds two functions to lock and unlock tables.

Log in or register to post comments

Comment #5

Cvbge CreditAttribution: Cvbge commented 23 August 2005 at 12:57

File	Size
locks_0.diff	2.8 KB

Updated, without unnecessary changes.

Log in or register to post comments

Comment #6

chx CreditAttribution: chx commented 23 August 2005 at 13:07

Status:

Needs review

» Reviewed & tested by the community

Cvbge says he tested pgsql, I applied to a mysql one, saved system settings and looks OK.

Log in or register to post comments

Comment #7

Cvbge CreditAttribution: Cvbge commented 23 August 2005 at 14:31

File	Size
locks_1.diff	2.81 KB

Worked, yet not worked ...
This version does not use db_query("{$table}" ) syntax. I promise I won't do that again!

Log in or register to post comments

Comment #8

Dries CreditAttribution: Dries commented 25 August 2005 at 21:10

MySQL is happy with the singular 'LOCK TABLE' (rather than 'LOCK TABLES') which should work with both MySQL and PostgreSQL. Committed that changes to CVS.

Log in or register to post comments

Comment #9

Dries CreditAttribution: Dries commented 25 August 2005 at 21:24

Status:

Reviewed & tested by the community

» Fixed

Log in or register to post comments

Comment #10

Cvbge CreditAttribution: Cvbge commented 25 August 2005 at 21:43

Status:

Fixed

» Reviewed & tested by the community

Please rollback your patch and either
a) use syntax LOCK TABLE name (dropping S and WRITE, if you say that mysql support "LOCK")
b) apply my patch.

Postgres does not support WRITE part (as well as S part).
Also locking won't work without starting transaction.

You can do LOCK TABLE name only, but this lock is too excessive and won't allow even SELECTs on locked table.

Log in or register to post comments

Comment #11

Cvbge CreditAttribution: Cvbge commented 26 August 2005 at 10:15

File	Size
drupal-head-lock.diff	2.82 KB

Attached updated patch for current head.

Log in or register to post comments

Comment #12

Thomas Ilsche CreditAttribution: Thomas Ilsche commented 27 August 2005 at 17:14

+1
tested the patch on pgsql, runs as expected.

Log in or register to post comments

Comment #13

Cvbge CreditAttribution: Cvbge commented 29 August 2005 at 19:11

File	Size
drupal-head-lock_0.diff	2.82 KB

Table names are now escaped

Log in or register to post comments

Comment #14

Dries CreditAttribution: Dries commented 29 August 2005 at 19:17

Status:

Reviewed & tested by the community

» Fixed

Committed to HEAD.

Log in or register to post comments

Comment #15

Cvbge CreditAttribution: Cvbge commented 3 September 2005 at 16:06

A sidenote about escaping table names:

db_escape_string() uses pg__escape_string(), from it's php docs: Escape a string for insertion into a text field. It assumes that it will be in ''. For example it does not esape ";"

mysql's version does addslashes, but it does not escape ";" either.

For postgresql correct way might be to use "" and escape ", but I'd have to check it. Is it worth it?