PG_QUERY ERROR - LOCK TABLES - IMPLEMENTATION FAULT.

this issue still exists, i've verified it on a fresh cvs install w/ pgsql 8

i fixed the problem in my installation, by changing the syntax to:

LOCK TABLE {cache}

it's table, not tables. and i dropped the 'write' bit.

furthermore, pgsql does not support the UNLOCK command, so i had to comment the unlock tables command. unless there are more lock/unlock commands elsewhere in the code, this works fine for me.

according to pgsql docs, UNLOCK is automatically performed at transaction end, which is why there is no such command.

The patch adds two functions to lock and unlock tables.

Updated, without unnecessary changes.

Cvbge says he tested pgsql, I applied to a mysql one, saved system settings and looks OK.

Worked, yet not worked ...
This version does not use db_query("{$table}" ) syntax. I promise I won't do that again!

MySQL is happy with the singular 'LOCK TABLE' (rather than 'LOCK TABLES') which should work with both MySQL and PostgreSQL. Committed that changes to CVS.

Please rollback your patch and either
a) use syntax LOCK TABLE name (dropping S and WRITE, if you say that mysql support "LOCK")
b) apply my patch.

Postgres does not support WRITE part (as well as S part).
Also locking won't work without starting transaction.

You can do LOCK TABLE name only, but this lock is too excessive and won't allow even SELECTs on locked table.

Attached updated patch for current head.

+1
tested the patch on pgsql, runs as expected.

Table names are now escaped

Committed to HEAD.

A sidenote about escaping table names:

db_escape_string() uses pg__escape_string(), from it's php docs: Escape a string for insertion into a text field. It assumes that it will be in ''. For example it does not esape ";"

mysql's version does addslashes, but it does not escape ";" either.

For postgresql correct way might be to use "" and escape ", but I'd have to check it. Is it worth it?