Remove the module_exists() as it is deprecated as per https://www.drupal.org/node/2205673.

submitted the patch for the same.

CommentFileSizeAuthor
#5 remove-module-exists-5.patch743 bytesjoshi.rohit100
#2 interdiff-remove-module-exists-2.txt323 bytesjoshi.rohit100
#2 remove-module-exists-2.patch758 bytesjoshi.rohit100
remove-module-exists.patch1.16 KBjoshi.rohit100

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Needs work 
+++ b/core/scripts/generate-d7-content.sh
@@ -171,7 +171,7 @@
-  else if (module_exists('blog')) {
+  else if (\Drupal::moduleHandler()->moduleExists('blog')) {

Even though it is very strange, that script should actually be run on a D7 code-base, so let's leave that alone. :-)

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
StatusFileSize
new remove-module-exists-2.patch758 bytes
new interdiff-remove-module-exists-2.txt323 bytes

updated patch as per #1

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work
Issue tags: -@depreacted +@deprecated, +Needs reroll 
git ac https://www.drupal.org/files/issues/remove-module-exists-2.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   758  100   758    0     0   1503      0 --:--:-- --:--:-- --:--:--  9132
error: patch failed: core/includes/bootstrap.inc:1181
error: core/includes/bootstrap.inc: patch does not apply
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new remove-module-exists-5.patch743 bytes

rerolled the patch.
Please review now.

ParisLiakos’s picture

ParisLiakos commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Looks like this is covered by the change record in https://www.drupal.org/node/1894902.

Committed and pushed to 8.x. Thanks!

  • webchick committed 17e7dba on 8.x 
    Issue #2300831 by joshi.rohit100: Remove module_exists() as it is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.